Skip to content

test(source/postgres): fix list_database_stats integration test#2196

Merged
Yuan325 merged 1 commit into
googleapis:mainfrom
srividyareddy786:dbtestfix
Dec 18, 2025
Merged

test(source/postgres): fix list_database_stats integration test#2196
Yuan325 merged 1 commit into
googleapis:mainfrom
srividyareddy786:dbtestfix

Conversation

@srividyareddy786

@srividyareddy786 srividyareddy786 commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

The list_database_stats test is flaky when run in parallel on the same shared instance. It fails with the error: failed to create test_user1: ERROR: role "test_user1" already exists. This test is updates to create a random role and database name to avoid conflicts with other simultaneously running tests.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<1738>

@srividyareddy786 srividyareddy786 requested a review from a team December 18, 2025 03:45
@gemini-code-assist

gemini-code-assist Bot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @srividyareddy786, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a known flakiness issue in the list_database_stats integration test. The test previously failed during parallel execution on shared instances due to conflicts arising from static database and user names. The solution involves dynamically generating unique names for these resources using UUIDs, thereby eliminating race conditions and ensuring the test's consistent success.

Highlights

  • Flaky Test Fix: Addresses the flakiness of the list_database_stats integration test, which previously failed when run in parallel due to existing role conflicts.
  • Parallel Test Stability: Enhances the reliability of tests executed concurrently on a shared instance by preventing resource naming collisions.
  • Dynamic Resource Naming: Implements the use of randomly generated UUIDs for database and user names within the test, ensuring uniqueness and avoiding 'role already exists' errors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 18, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a flaky integration test, list_database_stats, by replacing hardcoded database and user names with randomly generated ones using UUIDs. This is a good approach to prevent conflicts when tests are run in parallel. The implementation is correct, but there's an opportunity to improve code readability and reduce repetition. I've added a specific suggestion for this.

Comment thread tests/tool.go Outdated
@Yuan325 Yuan325 enabled auto-merge (squash) December 18, 2025 04:51
@Yuan325 Yuan325 added the tests: run Label to trigger Github Action tests. label Dec 18, 2025
@github-actions github-actions Bot removed the tests: run Label to trigger Github Action tests. label Dec 18, 2025
@Yuan325 Yuan325 merged commit 3fe4e2b into googleapis:main Dec 18, 2025
13 checks passed
github-actions Bot pushed a commit to santoshdahale/genai-toolbox-google-mcp that referenced this pull request Dec 18, 2025
@santoshdahale
deploy: test(source/postgres): fix list_database_stats integration te…
a9a0151 
…st (googleapis#2196)

## Description

> Should include a concise description of the changes (bug or feature),
it's
> impact, along with a summary of the solution

The list_database_stats test is flaky when run in parallel on the same
shared instance. It fails with the error: failed to create test_user1:
ERROR: role "test_user1" already exists. This test is updates to create
a random role and database name to avoid conflicts with other
simultaneously running tests.

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<1738> 3fe4e2b
github-actions Bot pushed a commit to SaxenaAnushka102/genai-toolbox that referenced this pull request Dec 18, 2025
@SaxenaAnushka102
deploy: test(source/postgres): fix list_database_stats integration te…
6396b74 
…st (googleapis#2196)

## Description

> Should include a concise description of the changes (bug or feature),
it's
> impact, along with a summary of the solution

The list_database_stats test is flaky when run in parallel on the same
shared instance. It fails with the error: failed to create test_user1:
ERROR: role "test_user1" already exists. This test is updates to create
a random role and database name to avoid conflicts with other
simultaneously running tests.

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<1738> 3fe4e2b
vinodhinic pushed a commit to vinodhinic/genai-toolbox that referenced this pull request Jan 14, 2026
@srividyareddy786 @vinodhinic-google
test(source/postgres): fix list_database_stats integration test (goog…
21bdfe1 
…leapis#2196)

## Description

> Should include a concise description of the changes (bug or feature),
it's
> impact, along with a summary of the solution

The list_database_stats test is flaky when run in parallel on the same
shared instance. It fails with the error: failed to create test_user1:
ERROR: role "test_user1" already exists. This test is updates to create
a random role and database name to avoid conflicts with other
simultaneously running tests.

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<1738>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuan325 Yuan325 Yuan325 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Yuan325 Yuan325

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srividyareddy786 @Yuan325