Skip to content

ci: Improved integration tests for looker#2187

Merged
drstrangelooker merged 2 commits into
mainfrom
looker-improve-integration-testing
Dec 17, 2025
Merged

ci: Improved integration tests for looker#2187
drstrangelooker merged 2 commits into
mainfrom
looker-improve-integration-testing

Conversation

@drstrangelooker

@drstrangelooker drstrangelooker commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Description

Improved integration tests for looker

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

@drstrangelooker drstrangelooker requested a review from a team December 16, 2025 20:12
@gemini-code-assist

gemini-code-assist Bot commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @drstrangelooker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the reliability and coverage of the Looker integration tests. It addresses a small but critical typo in a Looker tool's parameter handling and, more substantially, expands the test suite to include new Looker functionalities. The changes ensure that key operations like creating looks, dashboards, and managing dashboard elements and filters are thoroughly validated, contributing to a more stable and robust integration.

Highlights

  • Typo Fix: Corrected a minor typo in the lookeradddashboardfilter tool, changing the parameter name from flter_type to filter_type for accurate parameter parsing.
  • Expanded Looker Integration Tests: Significantly enhanced the Looker integration test suite by adding comprehensive tests for new functionalities, including make_look, make_dashboard, add_dashboard_filter, and add_dashboard_element.
  • New Test Helper Functions: Introduced dedicated test helper functions (testMakeLook, testMakeDashboard, testAddDashboardFilter, testAddDashboardElement) to streamline the creation, testing, and cleanup of Looker resources, ensuring robust and isolated test execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 16, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the integration tests for Looker by adding test coverage for the make_look, make_dashboard, add_dashboard_filter, and add_dashboard_element tools, along with a minor typo fix. The changes are good and increase test coverage. My review provides feedback to enhance the new tests by improving maintainability and robustness. Specifically, I've suggested refactoring duplicated code, using t.Fatalf for critical assertions to prevent misleading test failures, and adding assertions on response bodies to make the tests more thorough.

Comment thread tests/looker/looker_integration_test.go
Comment thread tests/looker/looker_integration_test.go
Comment thread tests/looker/looker_integration_test.go
Comment thread tests/looker/looker_integration_test.go
Comment thread tests/looker/looker_integration_test.go
Comment thread tests/looker/looker_integration_test.go
Yuan325
Yuan325 approved these changes Dec 17, 2025
View reviewed changes

@Yuan325 Yuan325 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drstrangelooker drstrangelooker merged commit 97b0e7d into main Dec 17, 2025
11 checks passed
@drstrangelooker drstrangelooker deleted the looker-improve-integration-testing branch December 17, 2025 18:30
@drstrangelooker drstrangelooker mentioned this pull request Dec 17, 2025
Closed
2 tasks
vinodhinic pushed a commit to vinodhinic/genai-toolbox that referenced this pull request Jan 14, 2026
@drstrangelooker @vinodhinic-google
ci: Improved integration tests for looker (googleapis#2187)
c9160ee 
## Description

Improved integration tests for looker

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuan325 Yuan325 Yuan325 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@duwenxin99 duwenxin99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drstrangelooker @Yuan325 @duwenxin99