Skip to content

chore: dedup GetCompatibleSource() across tools#2184

Merged
Yuan325 merged 2 commits into
config-branchfrom
dedup-getcompatiblesource
Dec 17, 2025
Merged

chore: dedup GetCompatibleSource() across tools#2184
Yuan325 merged 2 commits into
config-branchfrom
dedup-getcompatiblesource

Conversation

@Yuan325

@Yuan325 Yuan325 commented Dec 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added a generic GetCompatibleSource() in tools.go.

@Yuan325 Yuan325 requested review from a team December 15, 2025 20:01
@Yuan325 Yuan325 removed request for a team December 15, 2025 20:01
@Yuan325 Yuan325 assigned averikitsch and unassigned duwenxin99 Dec 15, 2025
@gemini-code-assist

gemini-code-assist Bot commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the codebase by introducing a generic helper function, tools.GetCompatibleSource, to standardize the process of retrieving and type-asserting compatible sources for various tools. This change eliminates redundant code patterns found across many tool implementations, leading to a cleaner, more maintainable, and less error-prone codebase.

Highlights

  • Code Refactoring: Introduced a new generic helper function, tools.GetCompatibleSource, to centralize the logic for retrieving and type-asserting sources.
  • Code Deduplication: Replaced repetitive GetSource() and type assertion blocks across numerous tool implementations with a single, consistent call to the new generic helper function.
  • Improved Maintainability: Enhanced code readability and reduced boilerplate by consolidating common source retrieval patterns into a reusable utility function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 15, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable refactoring by creating a generic GetCompatibleSource() function in tools.go. This effectively deduplicates the logic for retrieving and type-asserting data sources, which was previously repeated across numerous tool implementations. The new function is well-implemented and its application throughout the codebase is consistent and correct. This change significantly improves code maintainability and readability. The removal of now-unused err variable declarations in several files is also a good cleanup. Overall, this is an excellent improvement.

@Yuan325 Yuan325 force-pushed the dedup-getcompatiblesource branch from 69d9999 to fa96800 Compare December 15, 2025 22:41
Base automatically changed from run-lint to config-branch December 15, 2025 23:36
@Yuan325 Yuan325 merged commit b1d9a76 into config-branch Dec 17, 2025
10 of 11 checks passed
@Yuan325 Yuan325 deleted the dedup-getcompatiblesource branch December 17, 2025 17:02
Yuan325 added a commit that referenced this pull request Dec 17, 2025
@Yuan325
chore: dedup GetCompatibleSource() across tools (#2184)
f978823 
Added a generic `GetCompatibleSource()` in tools.go.
Yuan325 added a commit that referenced this pull request Dec 18, 2025
@Yuan325
chore: dedup GetCompatibleSource() across tools (#2184)
984534f 
Added a generic `GetCompatibleSource()` in tools.go.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore: dedup GetCompatibleSource() across tools (#2184)
f730c5c 
Added a generic `GetCompatibleSource()` in tools.go.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore: dedup GetCompatibleSource() across tools (#2184)
b7ca9c4 
Added a generic `GetCompatibleSource()` in tools.go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yuan325 @averikitsch @duwenxin99