feat(looker/tools): Enhance dashboard creation with dashboard filters#2133
Conversation
Summary of ChangesHello @drstrangelooker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to Looker dashboard creation by enabling the addition of interactive dashboard-level filters. This new functionality is exposed through a dedicated tool, and existing tools for adding dashboard elements have been updated to integrate with these filters. Beyond the new feature, the PR also includes a substantial overhaul of the documentation for various Looker tools, aiming to provide clearer, more detailed, and consistent information for developers and users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable new feature, the add_dashboard_filter tool, which enhances dashboard creation capabilities in Looker. The implementation of the new tool is solid, and the necessary adjustments to add_dashboard_element to support filter linking are well-executed.
I particularly appreciate the extensive updates to the documentation across all Looker tools. The new descriptions are much clearer, more structured, and provide better examples, which will significantly improve the developer experience.
I've left a few minor suggestions to improve code readability and fix a small documentation artifact. Overall, this is an excellent contribution.
1 similar comment
683208a to
a7f371b
Compare
1 similar comment
1732be7 to
860be2a
Compare
860be2a to
f643851
Compare
|
🧨 Preview deployments removed. |
… filters (#2133) ## Description Enhance dashboard creation with dashboard level filters. Also improve tool descriptions. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 285aa46
… filters (googleapis#2133) ## Description Enhance dashboard creation with dashboard level filters. Also improve tool descriptions. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 285aa46
… filters (googleapis#2133) ## Description Enhance dashboard creation with dashboard level filters. Also improve tool descriptions. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 285aa46
🤖 I have created a release *beep* *boop* --- ## [0.23.0](v0.22.0...v0.23.0) (2025-12-11) ### ⚠ BREAKING CHANGES * **serverless-spark:** add URLs to create batch tool outputs * **serverless-spark:** add URLs to list_batches output * **serverless-spark:** add Cloud Console and Logging URLs to get_batch * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](#2033)) ### Features * **tools/postgres:** Add list-table-stats-tool to list table statistics. ([#2055](#2055)) ([78b02f0](78b02f0)) * **looker/tools:** Enhance dashboard creation with dashboard filters ([#2133](#2133)) ([285aa46](285aa46)) * **serverless-spark:** Add Cloud Console and Logging URLs to get_batch ([e29c061](e29c061)) * **serverless-spark:** Add URLs to create batch tool outputs ([c6ccf4b](c6ccf4b)) * **serverless-spark:** Add URLs to list_batches output ([5605eab](5605eab)) * **sources/mariadb:** Add MariaDB source and MySQL tools integration ([#1908](#1908)) ([3b40fea](3b40fea)) * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](#2033)) ([489117d](489117d)) * **tools/postgres:** Add list_pg_settings, list_database_stats tools for postgres ([#2030](#2030)) ([32367a4](32367a4)) * **tools/postgres:** Add new postgres-list-roles tool ([#2038](#2038)) ([bea9705](bea9705)) ### Bug Fixes * List tables tools null fix ([#2107](#2107)) ([2b45266](2b45266)) * **tools/mongodb:** Removed sortPayload and sortParams ([#1238](#1238)) ([c5a6daa](c5a6daa)) ### Miscellaneous Chores * **looker:** Upgrade to latest go sdk ([#2159](#2159)) ([78e015d](78e015d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.23.0](v0.22.0...v0.23.0) (2025-12-11) ### ⚠ BREAKING CHANGES * **serverless-spark:** add URLs to create batch tool outputs * **serverless-spark:** add URLs to list_batches output * **serverless-spark:** add Cloud Console and Logging URLs to get_batch * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](#2033)) ### Features * **tools/postgres:** Add list-table-stats-tool to list table statistics. ([#2055](#2055)) ([78b02f0](78b02f0)) * **looker/tools:** Enhance dashboard creation with dashboard filters ([#2133](#2133)) ([285aa46](285aa46)) * **serverless-spark:** Add Cloud Console and Logging URLs to get_batch ([e29c061](e29c061)) * **serverless-spark:** Add URLs to create batch tool outputs ([c6ccf4b](c6ccf4b)) * **serverless-spark:** Add URLs to list_batches output ([5605eab](5605eab)) * **sources/mariadb:** Add MariaDB source and MySQL tools integration ([#1908](#1908)) ([3b40fea](3b40fea)) * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](#2033)) ([489117d](489117d)) * **tools/postgres:** Add list_pg_settings, list_database_stats tools for postgres ([#2030](#2030)) ([32367a4](32367a4)) * **tools/postgres:** Add new postgres-list-roles tool ([#2038](#2038)) ([bea9705](bea9705)) ### Bug Fixes * List tables tools null fix ([#2107](#2107)) ([2b45266](2b45266)) * **tools/mongodb:** Removed sortPayload and sortParams ([#1238](#1238)) ([c5a6daa](c5a6daa)) ### Miscellaneous Chores * **looker:** Upgrade to latest go sdk ([#2159](#2159)) ([78e015d](78e015d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 466aef0
🤖 I have created a release *beep* *boop* --- ## [0.23.0](googleapis/mcp-toolbox@v0.22.0...v0.23.0) (2025-12-11) ### ⚠ BREAKING CHANGES * **serverless-spark:** add URLs to create batch tool outputs * **serverless-spark:** add URLs to list_batches output * **serverless-spark:** add Cloud Console and Logging URLs to get_batch * **tools/postgres:** Add additional filter params for existing postgres tools ([googleapis#2033](googleapis#2033)) ### Features * **tools/postgres:** Add list-table-stats-tool to list table statistics. ([googleapis#2055](googleapis#2055)) ([78b02f0](googleapis@78b02f0)) * **looker/tools:** Enhance dashboard creation with dashboard filters ([googleapis#2133](googleapis#2133)) ([285aa46](googleapis@285aa46)) * **serverless-spark:** Add Cloud Console and Logging URLs to get_batch ([e29c061](googleapis@e29c061)) * **serverless-spark:** Add URLs to create batch tool outputs ([c6ccf4b](googleapis@c6ccf4b)) * **serverless-spark:** Add URLs to list_batches output ([5605eab](googleapis@5605eab)) * **sources/mariadb:** Add MariaDB source and MySQL tools integration ([googleapis#1908](googleapis#1908)) ([3b40fea](googleapis@3b40fea)) * **tools/postgres:** Add additional filter params for existing postgres tools ([googleapis#2033](googleapis#2033)) ([489117d](googleapis@489117d)) * **tools/postgres:** Add list_pg_settings, list_database_stats tools for postgres ([googleapis#2030](googleapis#2030)) ([32367a4](googleapis@32367a4)) * **tools/postgres:** Add new postgres-list-roles tool ([googleapis#2038](googleapis#2038)) ([bea9705](googleapis@bea9705)) ### Bug Fixes * List tables tools null fix ([googleapis#2107](googleapis#2107)) ([2b45266](googleapis@2b45266)) * **tools/mongodb:** Removed sortPayload and sortParams ([googleapis#1238](googleapis#1238)) ([c5a6daa](googleapis@c5a6daa)) ### Miscellaneous Chores * **looker:** Upgrade to latest go sdk ([googleapis#2159](googleapis#2159)) ([78e015d](googleapis@78e015d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 466aef0
…#2133) ## Description Enhance dashboard creation with dashboard level filters. Also improve tool descriptions. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change
🤖 I have created a release *beep* *boop* --- ## [0.23.0](v0.22.0...v0.23.0) (2025-12-11) ### ⚠ BREAKING CHANGES * **serverless-spark:** add URLs to create batch tool outputs * **serverless-spark:** add URLs to list_batches output * **serverless-spark:** add Cloud Console and Logging URLs to get_batch * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](#2033)) ### Features * **tools/postgres:** Add list-table-stats-tool to list table statistics. ([#2055](#2055)) ([78b02f0](78b02f0)) * **looker/tools:** Enhance dashboard creation with dashboard filters ([#2133](#2133)) ([285aa46](285aa46)) * **serverless-spark:** Add Cloud Console and Logging URLs to get_batch ([e29c061](e29c061)) * **serverless-spark:** Add URLs to create batch tool outputs ([c6ccf4b](c6ccf4b)) * **serverless-spark:** Add URLs to list_batches output ([5605eab](5605eab)) * **sources/mariadb:** Add MariaDB source and MySQL tools integration ([#1908](#1908)) ([3b40fea](3b40fea)) * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](#2033)) ([489117d](489117d)) * **tools/postgres:** Add list_pg_settings, list_database_stats tools for postgres ([#2030](#2030)) ([32367a4](32367a4)) * **tools/postgres:** Add new postgres-list-roles tool ([#2038](#2038)) ([bea9705](bea9705)) ### Bug Fixes * List tables tools null fix ([#2107](#2107)) ([2b45266](2b45266)) * **tools/mongodb:** Removed sortPayload and sortParams ([#1238](#1238)) ([c5a6daa](c5a6daa)) ### Miscellaneous Chores * **looker:** Upgrade to latest go sdk ([#2159](#2159)) ([78e015d](78e015d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
…googleapis#2133) ## Description Enhance dashboard creation with dashboard level filters. Also improve tool descriptions. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change
🤖 I have created a release *beep* *boop* --- ## [0.23.0](googleapis/mcp-toolbox@v0.22.0...v0.23.0) (2025-12-11) ### ⚠ BREAKING CHANGES * **serverless-spark:** add URLs to create batch tool outputs * **serverless-spark:** add URLs to list_batches output * **serverless-spark:** add Cloud Console and Logging URLs to get_batch * **tools/postgres:** Add additional filter params for existing postgres tools ([googleapis#2033](googleapis#2033)) ### Features * **tools/postgres:** Add list-table-stats-tool to list table statistics. ([googleapis#2055](googleapis#2055)) ([78b02f0](googleapis@78b02f0)) * **looker/tools:** Enhance dashboard creation with dashboard filters ([googleapis#2133](googleapis#2133)) ([285aa46](googleapis@285aa46)) * **serverless-spark:** Add Cloud Console and Logging URLs to get_batch ([e29c061](googleapis@e29c061)) * **serverless-spark:** Add URLs to create batch tool outputs ([c6ccf4b](googleapis@c6ccf4b)) * **serverless-spark:** Add URLs to list_batches output ([5605eab](googleapis@5605eab)) * **sources/mariadb:** Add MariaDB source and MySQL tools integration ([googleapis#1908](googleapis#1908)) ([3b40fea](googleapis@3b40fea)) * **tools/postgres:** Add additional filter params for existing postgres tools ([googleapis#2033](googleapis#2033)) ([489117d](googleapis@489117d)) * **tools/postgres:** Add list_pg_settings, list_database_stats tools for postgres ([googleapis#2030](googleapis#2030)) ([32367a4](googleapis@32367a4)) * **tools/postgres:** Add new postgres-list-roles tool ([googleapis#2038](googleapis#2038)) ([bea9705](googleapis@bea9705)) ### Bug Fixes * List tables tools null fix ([googleapis#2107](googleapis#2107)) ([2b45266](googleapis@2b45266)) * **tools/mongodb:** Removed sortPayload and sortParams ([googleapis#1238](googleapis#1238)) ([c5a6daa](googleapis@c5a6daa)) ### Miscellaneous Chores * **looker:** Upgrade to latest go sdk ([googleapis#2159](googleapis#2159)) ([78e015d](googleapis@78e015d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.23.0](googleapis/mcp-toolbox@v0.22.0...v0.23.0) (2025-12-11) ### ⚠ BREAKING CHANGES * **serverless-spark:** add URLs to create batch tool outputs * **serverless-spark:** add URLs to list_batches output * **serverless-spark:** add Cloud Console and Logging URLs to get_batch * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](googleapis/mcp-toolbox#2033)) ### Features * **tools/postgres:** Add list-table-stats-tool to list table statistics. ([#2055](googleapis/mcp-toolbox#2055)) ([78b02f0](googleapis/mcp-toolbox@78b02f0)) * **looker/tools:** Enhance dashboard creation with dashboard filters ([#2133](googleapis/mcp-toolbox#2133)) ([285aa46](googleapis/mcp-toolbox@285aa46)) * **serverless-spark:** Add Cloud Console and Logging URLs to get_batch ([e29c061](googleapis/mcp-toolbox@e29c061)) * **serverless-spark:** Add URLs to create batch tool outputs ([c6ccf4b](googleapis/mcp-toolbox@c6ccf4b)) * **serverless-spark:** Add URLs to list_batches output ([5605eab](googleapis/mcp-toolbox@5605eab)) * **sources/mariadb:** Add MariaDB source and MySQL tools integration ([#1908](googleapis/mcp-toolbox#1908)) ([3b40fea](googleapis/mcp-toolbox@3b40fea)) * **tools/postgres:** Add additional filter params for existing postgres tools ([#2033](googleapis/mcp-toolbox#2033)) ([489117d](googleapis/mcp-toolbox@489117d)) * **tools/postgres:** Add list_pg_settings, list_database_stats tools for postgres ([#2030](googleapis/mcp-toolbox#2030)) ([32367a4](googleapis/mcp-toolbox@32367a4)) * **tools/postgres:** Add new postgres-list-roles tool ([#2038](googleapis/mcp-toolbox#2038)) ([bea9705](googleapis/mcp-toolbox@bea9705)) ### Bug Fixes * List tables tools null fix ([#2107](googleapis/mcp-toolbox#2107)) ([2b45266](googleapis/mcp-toolbox@2b45266)) * **tools/mongodb:** Removed sortPayload and sortParams ([#1238](googleapis/mcp-toolbox#1238)) ([c5a6daa](googleapis/mcp-toolbox@c5a6daa)) ### Miscellaneous Chores * **looker:** Upgrade to latest go sdk ([#2159](googleapis/mcp-toolbox#2159)) ([78e015d](googleapis/mcp-toolbox@78e015d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
Description
Enhance dashboard creation with dashboard level filters. Also improve tool descriptions.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change