Skip to content

chore(tools/serverlessspark): decouple source config from tools#2069

Merged
Yuan325 merged 1 commit into
config-branchfrom
config-serverlessspark
Dec 11, 2025
Merged

chore(tools/serverlessspark): decouple source config from tools#2069
Yuan325 merged 1 commit into
config-branchfrom
config-serverlessspark

Conversation

@Yuan325

@Yuan325 Yuan325 commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.

@Yuan325 Yuan325 requested a review from a team November 27, 2025 17:29
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the internal Serverless Spark tools by abstracting their dependency on the concrete serverlessspark.Source implementation. By introducing a compatibleSource interface and dynamically retrieving source information, the changes enhance modularity and reduce tight coupling, making the tools more flexible and easier to maintain. This refactoring ensures that tools interact with sources through a well-defined contract, improving the overall design of the system.

Highlights

  • Decoupling Source Configuration: The pull request decouples the direct dependency of Serverless Spark tools on the serverlessspark.Source type, promoting a more modular architecture.
  • Introduction of compatibleSource Interface: A new compatibleSource interface has been introduced in the Serverless Spark tools, defining the necessary methods (GetOperationsClient, GetBatchControllerClient, GetProject, GetLocation) that tools require from a source.
  • Dynamic Source Retrieval: Tools now retrieve their associated source dynamically via resourceMgr.GetSource() and cast it to the compatibleSource interface, rather than holding a direct reference to a concrete serverlessspark.Source.
  • New Methods in serverlessspark.Source: The serverlessspark.Source struct now includes GetProject() and GetLocation() methods to expose project and location details, which are utilized by the refactored tools.
  • Updated Tool Method Signatures: The RequiresClientAuthorization and GetAuthTokenHeaderName methods in the Serverless Spark tools have been updated to return an error in addition to their previous return values, aligning with a common pattern for operations that might fail.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively decouples the serverlessspark tools from the concrete serverlessspark.Source implementation by introducing local interfaces and resolving the source at invocation time. This is a great improvement for maintainability and testability. My review includes suggestions to further enhance maintainability by reducing code duplication that has been introduced. Specifically, I've pointed out repeated logic for source retrieval in the Invoke functions and a duplicated interface definition.

@averikitsch averikitsch assigned averikitsch and unassigned duwenxin99 Dec 1, 2025
Base automatically changed from config-server to config-branch December 9, 2025 01:36
@Yuan325 Yuan325 force-pushed the config-serverlessspark branch from dca1813 to bc5e307 Compare December 11, 2025 04:08
@Yuan325 Yuan325 merged commit dae8a6d into config-branch Dec 11, 2025
6 of 11 checks passed
@Yuan325 Yuan325 deleted the config-serverlessspark branch December 11, 2025 04:10
Yuan325 added a commit that referenced this pull request Dec 17, 2025
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 18, 2025
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants