chore(tools/serverlessspark): decouple source config from tools#2069
Conversation
Summary of ChangesHello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the internal Serverless Spark tools by abstracting their dependency on the concrete Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively decouples the serverlessspark tools from the concrete serverlessspark.Source implementation by introducing local interfaces and resolving the source at invocation time. This is a great improvement for maintainability and testability. My review includes suggestions to further enhance maintainability by reducing code duplication that has been introduced. Specifically, I've pointed out repeated logic for source retrieval in the Invoke functions and a duplicated interface definition.
dca1813 to
bc5e307
Compare
Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.
Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.
Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.
Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.
Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.