Skip to content

chore(tools/looker): decouple source config from tools#2066

Merged
Yuan325 merged 3 commits into
config-branchfrom
config-looker
Dec 13, 2025
Merged

chore(tools/looker): decouple source config from tools#2066
Yuan325 merged 3 commits into
config-branchfrom
config-looker

Conversation

@Yuan325

@Yuan325 Yuan325 commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.

@Yuan325 Yuan325 requested a review from a team November 27, 2025 17:26
@gemini-code-assist

gemini-code-assist Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way Looker tools interact with their underlying source configurations. By introducing a dynamic retrieval mechanism through the ResourceManager and defining a compatibleSource interface, it significantly reduces tight coupling between tools and specific source implementations. This change enhances modularity, simplifies tool configuration, and makes the system more adaptable to future source variations.

Highlights

  • Decoupling Source Configuration: The core change involves decoupling source-specific configurations (like API settings, client details, and authorization flags) directly from individual tool structs. Instead, tools now dynamically retrieve these properties from the ResourceManager via a SourceProvider interface during their Invoke() and RequiresClientAuthorization() calls.
  • Refactored Tool Interface: The Tool interface's GetAuthTokenHeaderName method has been updated to accept a SourceProvider and return an error, reflecting the new dynamic retrieval mechanism. This change is propagated to all Looker-related tools and their mock implementations.
  • New Source Accessor Methods: The looker.Source struct now exposes dedicated accessor methods (e.g., LookerClient(), LookerApiSettings(), LookerShowHiddenFields()) to provide specific Looker properties, enabling tools to fetch only what they need at runtime.
  • Consistent Source Handling in Tools: All Looker-specific tools (lookeradddashboardelement, lookerconversationalanalytics, etc.) have been updated to remove direct storage of source properties. They now define a compatibleSource interface and use it to fetch necessary details from the ResourceManager during execution, improving modularity and reducing boilerplate.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 27, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant refactoring that successfully decouples the Looker tools from their source configurations. By introducing a compatibleSource interface and fetching source details at invocation time, the code becomes more modular and maintainable. The changes are applied consistently across a large number of files.

I have two main pieces of feedback. First, there is considerable code duplication in retrieving and type-asserting the source within each tool. I've suggested creating a helper function to address this. Second, in the lookerhealthpulse tool, there's a small redundancy in how API settings are handled, which could be cleaned up for better clarity. My comments provide specific suggestions for these improvements. Overall, this is a well-executed and valuable refactoring.

Comment thread internal/tools/looker/lookeradddashboardelement/lookeradddashboardelement.go
Comment thread internal/tools/looker/lookerhealthpulse/lookerhealthpulse.go
@averikitsch averikitsch assigned averikitsch and unassigned duwenxin99 Dec 1, 2025
Base automatically changed from config-server to config-branch December 9, 2025 01:36
@Yuan325 Yuan325 requested a review from a team December 9, 2025 01:36
@Yuan325 Yuan325 merged commit b0392b3 into config-branch Dec 13, 2025
6 of 11 checks passed
@Yuan325 Yuan325 deleted the config-looker branch December 13, 2025 15:10
Yuan325 added a commit that referenced this pull request Dec 17, 2025
@Yuan325
chore(tools/looker): decouple source config from tools (#2066)
4763088 
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 18, 2025
@Yuan325
chore(tools/looker): decouple source config from tools (#2066)
d6e4c40 
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore(tools/looker): decouple source config from tools (#2066)
86a4e3d 
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore(tools/looker): decouple source config from tools (#2066)
d44c1df 
Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yuan325 @averikitsch @duwenxin99