Skip to content

chore(tools/cloudhealthcare,tools/cloudmonitoring): decouple source config from tools#2062

Merged
Yuan325 merged 1 commit into
config-branchfrom
config-cloudhealthcare
Dec 13, 2025
Merged

chore(tools/cloudhealthcare,tools/cloudmonitoring): decouple source config from tools#2062
Yuan325 merged 1 commit into
config-branchfrom
config-cloudhealthcare

Conversation

@Yuan325

@Yuan325 Yuan325 commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Within Invoke() and RequiresClientAuthorization(), get Source from ResourceManager and use it to call functions directly.

@Yuan325 Yuan325 requested a review from a team November 27, 2025 17:21
@gemini-code-assist

gemini-code-assist Bot commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the internal architecture of the cloud healthcare and cloud monitoring tools. The core change involves shifting from tools directly holding source-specific configuration to dynamically querying a SourceProvider for these details at runtime. This enhances the flexibility and maintainability of the toolset by reducing direct dependencies and promoting a more pluggable design for data sources.

Highlights

  • Decoupling Source Configuration: The pull request refactors cloudhealthcare and cloudmonitoring tools to decouple source-specific configuration (like project, region, dataset, client, base URL, user agent) from the tool's internal state. These details are now dynamically retrieved from a SourceProvider during tool invocation.
  • Improved Modularity: By removing direct storage of source configuration within tool structs, the design promotes better modularity and reduces tight coupling, making tools more generic and reusable.
  • Enhanced RequiresClientAuthorization: The RequiresClientAuthorization method in affected tools now fetches authorization requirements directly from the source via the SourceProvider and returns an error type, aligning with the new dynamic retrieval pattern.
  • Private Fields and Getters in cloudmonitoring source: The cloudmonitoring source (cloud_monitoring.go) has been updated to make BaseURL, Client, and UserAgent fields private, introducing public getter methods for controlled access.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 27, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors a significant number of tools to decouple them from their sources during initialization. Instead, sources are retrieved from a SourceProvider at invocation time. This is a positive architectural change that improves modularity. My review focuses on a pattern of code duplication introduced by this change across the cloudhealthcare tools, and a minor cleanup in the cloudmonitoring source. Addressing the duplication will further improve the maintainability of the new design.

Comment thread internal/sources/cloudmonitoring/cloud_monitoring.go Outdated
Comment thread internal/tools/cloudhealthcare/cloudhealthcarefhirfetchpage/cloudhealthcarefhirfetchpage.go
@averikitsch averikitsch assigned averikitsch and unassigned duwenxin99 Dec 1, 2025
Base automatically changed from config-server to config-branch December 9, 2025 01:36
averikitsch
averikitsch reviewed Dec 9, 2025
View reviewed changes
Comment thread internal/sources/cloudmonitoring/cloud_monitoring.go Outdated
@Yuan325 Yuan325 force-pushed the config-cloudhealthcare branch from 0183165 to 90ab809 Compare December 11, 2025 17:56
@Yuan325 Yuan325 requested a review from averikitsch December 11, 2025 17:57
@Yuan325 Yuan325 merged commit f90d1ed into config-branch Dec 13, 2025
6 of 11 checks passed
@Yuan325 Yuan325 deleted the config-cloudhealthcare branch December 13, 2025 04:23
Yuan325 added a commit that referenced this pull request Dec 17, 2025
@Yuan325
chore(tools/cloudhealthcare,tools/cloudmonitoring): decouple source c…
82b0679 
…onfig from tools (#2062)

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 18, 2025
@Yuan325
chore(tools/cloudhealthcare,tools/cloudmonitoring): decouple source c…
da24bc1 
…onfig from tools (#2062)

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore(tools/cloudhealthcare,tools/cloudmonitoring): decouple source c…
1c419b0 
…onfig from tools (#2062)

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Yuan325 added a commit that referenced this pull request Dec 19, 2025
@Yuan325
chore(tools/cloudhealthcare,tools/cloudmonitoring): decouple source c…
a8ec530 
…onfig from tools (#2062)

Within Invoke() and RequiresClientAuthorization(), get Source from
ResourceManager and use it to call functions directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yuan325 @averikitsch @duwenxin99