Skip to content

fix(tools/alloydbgetinstance): remove parameter duplication#1993

Merged
Yuan325 merged 1 commit into
mainfrom
alloydb-fix
Nov 19, 2025
Merged

fix(tools/alloydbgetinstance): remove parameter duplication#1993
Yuan325 merged 1 commit into
mainfrom
alloydb-fix

Conversation

@Yuan325

@Yuan325 Yuan325 commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Previous merge conflict caused parameter duplications

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes gemini-cli-extensions/alloydb#97

@gemini-code-assist

gemini-code-assist Bot commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important code cleanup within the alloydbgetinstance tool. It rectifies an issue stemming from a past merge conflict that introduced duplicate parameter definitions. By removing these redundant lines, the change ensures the tool's parameter initialization is correct and free from unnecessary code, contributing to overall code quality and maintainability.

Highlights

  • Parameter Duplication Fix: This pull request resolves an issue where parameter definitions for 'location', 'cluster', and 'instance' were duplicated within the alloydbgetinstance tool's initialization logic.
  • Root Cause: The duplication was identified as a consequence of a previous merge conflict, leading to redundant code.
  • Affected Component: The fix specifically targets the internal/tools/alloydb/alloydbgetinstance/alloydbgetinstance.go file, ensuring clean parameter setup.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 19, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes duplicated parameter definitions in the alloydbgetinstance tool, which were likely introduced during a merge conflict. This is an important fix as the duplication could lead to incorrect tool manifest generation and runtime errors. The change is accurate and improves the code's correctness.

@Yuan325 Yuan325 enabled auto-merge (squash) November 19, 2025 19:39
@Yuan325 Yuan325 merged commit 0e269a1 into main Nov 19, 2025
11 checks passed
@Yuan325 Yuan325 deleted the alloydb-fix branch November 19, 2025 19:43
@release-please release-please Bot mentioned this pull request Nov 19, 2025
Merged
Yuan325 added a commit that referenced this pull request Nov 19, 2025
@release-please @Yuan325
chore(main): release 0.21.0 (#1957)
e81dfea 
🤖 I have created a release *beep* *boop*
---


##
[0.21.0](v0.20.0...v0.21.0)
(2025-11-19)


### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([#1894](#1894))
([446d62a](446d62a))


### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([#1751](#1751))
([5abad5d](5abad5d))


### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([#1993](#1993))
([0e269a1](0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([#1969](#1969))
([2bff138](2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
github-actions Bot pushed a commit that referenced this pull request Nov 19, 2025
@Yuan325 @release-please
deploy: chore(main): release 0.21.0 (#1957)
ca20bb2 
🤖 I have created a release *beep* *boop*
---

##
[0.21.0](v0.20.0...v0.21.0)
(2025-11-19)

### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([#1894](#1894))
([446d62a](446d62a))

### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([#1751](#1751))
([5abad5d](5abad5d))

### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([#1993](#1993))
([0e269a1](0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([#1969](#1969))
([2bff138](2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> e81dfea
github-actions Bot pushed a commit that referenced this pull request Nov 19, 2025
@Yuan325 @release-please
deploy: chore(main): release 0.21.0 (#1957)
a66daca 
🤖 I have created a release *beep* *boop*
---

##
[0.21.0](v0.20.0...v0.21.0)
(2025-11-19)

### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([#1894](#1894))
([446d62a](446d62a))

### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([#1751](#1751))
([5abad5d](5abad5d))

### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([#1993](#1993))
([0e269a1](0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([#1969](#1969))
([2bff138](2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> e81dfea
github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Nov 19, 2025
@renovate-bot @release-please
deploy: chore(main): release 0.21.0 (googleapis#1957)
401d9d4 
🤖 I have created a release *beep* *boop*
---

##
[0.21.0](googleapis/mcp-toolbox@v0.20.0...v0.21.0)
(2025-11-19)

### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([googleapis#1894](googleapis#1894))
([446d62a](googleapis@446d62a))

### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([googleapis#1751](googleapis#1751))
([5abad5d](googleapis@5abad5d))

### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([googleapis#1993](googleapis#1993))
([0e269a1](googleapis@0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([googleapis#1969](googleapis#1969))
([2bff138](googleapis@2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> e81dfea
github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Nov 19, 2025
@renovate-bot @release-please
deploy: chore(main): release 0.21.0 (googleapis#1957)
dffa30b 
🤖 I have created a release *beep* *boop*
---

##
[0.21.0](googleapis/mcp-toolbox@v0.20.0...v0.21.0)
(2025-11-19)

### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([googleapis#1894](googleapis#1894))
([446d62a](googleapis@446d62a))

### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([googleapis#1751](googleapis#1751))
([5abad5d](googleapis@5abad5d))

### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([googleapis#1993](googleapis#1993))
([0e269a1](googleapis@0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([googleapis#1969](googleapis#1969))
([2bff138](googleapis@2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> e81dfea
github-actions Bot pushed a commit to bhardwajRahul/genai-toolbox that referenced this pull request Nov 19, 2025
@pull
deploy: fix(tools/alloydbgetinstance): remove parameter duplication (g…
e78a927 
…oogleapis#1993)

## Description

Previous merge conflict caused parameter duplications

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change

🛠️ Fixes gemini-cli-extensions/alloydb#97 0e269a1
github-actions Bot pushed a commit to bhardwajRahul/genai-toolbox that referenced this pull request Nov 19, 2025
@pull
deploy: fix(tools/alloydbgetinstance): remove parameter duplication (g…
eda81d7 
…oogleapis#1993)

## Description

Previous merge conflict caused parameter duplications

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [x] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [x] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
- [x] Make sure to add `!` if this involve a breaking change

🛠️ Fixes gemini-cli-extensions/alloydb#97 0e269a1
@BrewTestBot BrewTestBot mentioned this pull request Nov 19, 2025
Merged
github-actions Bot pushed a commit to CrazyForks/genai-toolbox that referenced this pull request Nov 20, 2025
@pull @release-please
deploy: chore(main): release 0.21.0 (googleapis#1957)
742588a 
🤖 I have created a release *beep* *boop*
---

##
[0.21.0](googleapis/mcp-toolbox@v0.20.0...v0.21.0)
(2025-11-19)

### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([googleapis#1894](googleapis#1894))
([446d62a](googleapis@446d62a))

### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([googleapis#1751](googleapis#1751))
([5abad5d](googleapis@5abad5d))

### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([googleapis#1993](googleapis#1993))
([0e269a1](googleapis@0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([googleapis#1969](googleapis#1969))
([2bff138](googleapis@2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> e81dfea
@github-actions github-actions Bot mentioned this pull request Feb 20, 2026
Open
6 tasks
NightStack15 added a commit to NightStack15/googleapis-_-genai-toolbox that referenced this pull request Mar 20, 2026
@NightStack15 @release-please @Yuan325
chore(main): release 0.21.0 (#1957)
624cc76 
🤖 I have created a release *beep* *boop*
---


##
[0.21.0](googleapis/mcp-toolbox@v0.20.0...v0.21.0)
(2025-11-19)


### ⚠ BREAKING CHANGES

* **tools/spanner-list-tables:** Unmarshal `object_details` json string
into map to make response have nested json
([#1894](googleapis/mcp-toolbox#1894))
([446d62a](googleapis/mcp-toolbox@446d62a))


### Features

* **tools/postgres:** Add `long_running_transactions`, `list_locks` and
`replication_stats` tools
([#1751](googleapis/mcp-toolbox#1751))
([5abad5d](googleapis/mcp-toolbox@5abad5d))


### Bug Fixes

* **tools/alloydbgetinstance:** Remove parameter duplication
([#1993](googleapis/mcp-toolbox#1993))
([0e269a1](googleapis/mcp-toolbox@0e269a1))
* **tools:** Check for query execution error for pgxpool.Pool
([#1969](googleapis/mcp-toolbox#1969))
([2bff138](googleapis/mcp-toolbox@2bff138))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

alloydb extension leads to "duplicate elements in 'required' at top-level are forbidden" error

2 participants

@Yuan325 @averikitsch