Skip to content

fix: remove custom promptset support#1863

Merged
twishabansal merged 3 commits into
feat-promptfrom
remove-promptsets
Nov 11, 2025
Merged

fix: remove custom promptset support#1863
twishabansal merged 3 commits into
feat-promptfrom
remove-promptsets

Conversation

@twishabansal

@twishabansal twishabansal commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@twishabansal twishabansal changed the title fix: remove support for custom promptsets fix: remove custom promptset support Nov 5, 2025
@twishabansal twishabansal marked this pull request as ready for review November 5, 2025 19:51
@twishabansal twishabansal requested a review from a team November 5, 2025 19:51
@twishabansal twishabansal requested a review from Yuan325 November 5, 2025 19:51
@twishabansal twishabansal assigned Yuan325 and unassigned averikitsch Nov 5, 2025

@Yuan325 Yuan325 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please resolve the feedback before merging.

Comment thread cmd/root.go
Comment thread cmd/root.go
@twishabansal twishabansal merged commit 368bdef into feat-prompt Nov 11, 2025
9 of 11 checks passed
@twishabansal twishabansal deleted the remove-promptsets branch November 11, 2025 10:05
twishabansal added a commit that referenced this pull request Nov 11, 2025
twishabansal added a commit that referenced this pull request Nov 11, 2025
@twishabansal twishabansal restored the remove-promptsets branch November 11, 2025 10:09
twishabansal added a commit that referenced this pull request Nov 11, 2025
## Description

Accidentally merged
#1863 into
#1798 without adding a
fix. Reverted that and copying it with the fix here.

## PR Checklist

> Thank you for opening a Pull Request! Before submitting your PR, there
are a
> few things you can do to make sure it goes smoothly:

- [ ] Make sure you reviewed

[CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md)
- [ ] Make sure to open an issue as a

[bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose)
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Make sure to add `!` if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants