fix(sources/mysql): escape mysql user agent#1707
Merged
Merged
Conversation
duwenxin99
approved these changes
Oct 15, 2025
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Oct 15, 2025
## Description > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1695 eeb694c
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Oct 15, 2025
## Description > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1695 eeb694c
duwenxin99
added a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 3ca58b1
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 3ca58b1
github-actions Bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](googleapis/mcp-toolbox@v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([googleapis#1770](googleapis#1770)) ([eaf7740](googleapis@eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([googleapis#1673](googleapis#1673)) ([089081f](googleapis@089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([googleapis#1707](googleapis#1707)) ([eeb694c](googleapis@eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([googleapis#1717](googleapis#1717)) ([02f7f8a](googleapis@02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([googleapis#1761](googleapis#1761)) ([a06d0d8](googleapis@a06d0d8)) * **tools/http:** Omit optional nil query parameters ([googleapis#1762](googleapis#1762)) ([bd16ba3](googleapis@bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([googleapis#1758](googleapis#1758)) ([336de1b](googleapis@336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 3ca58b1
github-actions Bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](googleapis/mcp-toolbox@v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([googleapis#1770](googleapis#1770)) ([eaf7740](googleapis@eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([googleapis#1673](googleapis#1673)) ([089081f](googleapis@089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([googleapis#1707](googleapis#1707)) ([eeb694c](googleapis@eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([googleapis#1717](googleapis#1717)) ([02f7f8a](googleapis@02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([googleapis#1761](googleapis#1761)) ([a06d0d8](googleapis@a06d0d8)) * **tools/http:** Omit optional nil query parameters ([googleapis#1762](googleapis#1762)) ([bd16ba3](googleapis@bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([googleapis#1758](googleapis#1758)) ([336de1b](googleapis@336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 3ca58b1
github-actions Bot
pushed a commit
to bhardwajRahul/genai-toolbox
that referenced
this pull request
Oct 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](googleapis/mcp-toolbox@v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([googleapis#1770](googleapis#1770)) ([eaf7740](googleapis@eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([googleapis#1673](googleapis#1673)) ([089081f](googleapis@089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([googleapis#1707](googleapis#1707)) ([eeb694c](googleapis@eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([googleapis#1717](googleapis#1717)) ([02f7f8a](googleapis@02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([googleapis#1761](googleapis#1761)) ([a06d0d8](googleapis@a06d0d8)) * **tools/http:** Omit optional nil query parameters ([googleapis#1762](googleapis#1762)) ([bd16ba3](googleapis@bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([googleapis#1758](googleapis#1758)) ([336de1b](googleapis@336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 3ca58b1
github-actions Bot
pushed a commit
to bhardwajRahul/genai-toolbox
that referenced
this pull request
Oct 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](googleapis/mcp-toolbox@v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([googleapis#1770](googleapis#1770)) ([eaf7740](googleapis@eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([googleapis#1673](googleapis#1673)) ([089081f](googleapis@089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([googleapis#1707](googleapis#1707)) ([eeb694c](googleapis@eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([googleapis#1717](googleapis#1717)) ([02f7f8a](googleapis@02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([googleapis#1761](googleapis#1761)) ([a06d0d8](googleapis@a06d0d8)) * **tools/http:** Omit optional nil query parameters ([googleapis#1762](googleapis#1762)) ([bd16ba3](googleapis@bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([googleapis#1758](googleapis#1758)) ([336de1b](googleapis@336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 3ca58b1
twishabansal
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Description > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #1695
twishabansal
pushed a commit
that referenced
this pull request
Oct 27, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
rahulpinto19
pushed a commit
that referenced
this pull request
Oct 27, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
rahulpinto19
pushed a commit
that referenced
this pull request
Oct 27, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
2 tasks
twishabansal
pushed a commit
that referenced
this pull request
Oct 28, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](#1770)) ([eaf7740](eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](#1673)) ([089081f](089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](#1707)) ([eeb694c](eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](#1717)) ([02f7f8a](02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](#1761)) ([a06d0d8](a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](#1762)) ([bd16ba3](bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](#1758)) ([336de1b](336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
srividyareddy786
pushed a commit
to srividyareddy786/genai-toolbox
that referenced
this pull request
Nov 4, 2025
## Description > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1695
srividyareddy786
pushed a commit
to srividyareddy786/genai-toolbox
that referenced
this pull request
Nov 4, 2025
🤖 I have created a release *beep* *boop* --- ## [0.18.0](googleapis/mcp-toolbox@v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([googleapis#1770](googleapis#1770)) ([eaf7740](googleapis@eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([googleapis#1673](googleapis#1673)) ([089081f](googleapis@089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([googleapis#1707](googleapis#1707)) ([eeb694c](googleapis@eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([googleapis#1717](googleapis#1717)) ([02f7f8a](googleapis@02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([googleapis#1761](googleapis#1761)) ([a06d0d8](googleapis@a06d0d8)) * **tools/http:** Omit optional nil query parameters ([googleapis#1762](googleapis#1762)) ([bd16ba3](googleapis@bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([googleapis#1758](googleapis#1758)) ([336de1b](googleapis@336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
6 tasks
NightStack15
added a commit
to NightStack15/googleapis-_-genai-toolbox
that referenced
this pull request
Mar 20, 2026
🤖 I have created a release *beep* *boop* --- ## [0.18.0](googleapis/mcp-toolbox@v0.17.0...v0.18.0) (2025-10-23) ### Features * Support `allowedValues`, `escape`, `minValue` and `maxValue` for parameters ([#1770](googleapis/mcp-toolbox#1770)) ([eaf7740](googleapis/mcp-toolbox@eaf7740)) * **tools/looker:** Tools to allow the agent to retrieve, create, modify, and delete LookML project files. ([#1673](googleapis/mcp-toolbox#1673)) ([089081f](googleapis/mcp-toolbox@089081f)) ### Bug Fixes * **sources/mysql:** Escape mysql user agent ([#1707](googleapis/mcp-toolbox#1707)) ([eeb694c](googleapis/mcp-toolbox@eeb694c)) * **sources/mysql:** Escape program_name for MySQL ([#1717](googleapis/mcp-toolbox#1717)) ([02f7f8a](googleapis/mcp-toolbox@02f7f8a)) * **tools/http:** Allow 2xx status code on tool invocation ([#1761](googleapis/mcp-toolbox#1761)) ([a06d0d8](googleapis/mcp-toolbox@a06d0d8)) * **tools/http:** Omit optional nil query parameters ([#1762](googleapis/mcp-toolbox#1762)) ([bd16ba3](googleapis/mcp-toolbox@bd16ba3)) * **tools/looker:** Looker file content calls should not use url.QueryEscape ([#1758](googleapis/mcp-toolbox#1758)) ([336de1b](googleapis/mcp-toolbox@336de1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #1695