feat(sidekick): Relax AIP checks for samples of delete operations#3519
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of AIP-135 compliance checks for delete operations within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request relaxes the checks for what is considered a standard AIP delete operation. It now also considers fields named name for resources without a singular name, which makes the check more flexible. The logic for finding the resource name field is updated with a clear prioritization, and this is well-supported by new test cases. The changes are solid, I just have one minor suggestion to fix a typo in a comment.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
=======================================
Coverage 81.03% 81.04%
=======================================
Files 166 166
Lines 13775 13782 +7
=======================================
+ Hits 11163 11170 +7
Misses 2032 2032
Partials 580 580 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Not all resources define a singular name so we can't rely on that only. We now also look at fields named `name` with no-singular resource.
a9c388c to
2263b99
Compare
|
This is ready for review, latest counterpart in googleapis/google-cloud-rust#4245. |
coryan
left a comment
There was a problem hiding this comment.
A small comment nit, feel free to merge and then fix in a follow-up PR.
This includes the baseline sample for all simple RPCs (non-LRO and non-paginated) plus specific samples for get and non-LRO deletes. Its latest counterpart is googleapis/librarian#3519 Best to review one commit at a time.
Not all resources define a singular name so we can't rely on that only. We now also look at fields named
namewith no-singular resource.