This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix(test): update NIOTest to ensure LocalStorageHelper is used#552
Merged
gcf-merge-on-green[bot] merged 1 commit intomasterfrom May 11, 2021
Merged
fix(test): update NIOTest to ensure LocalStorageHelper is used#552gcf-merge-on-green[bot] merged 1 commit intomasterfrom
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
Conversation
When starting a test, there is a `gs://` uri which is referenced before any unit test level configuration of CloudStorageFileSystemProvider. If NIOTest runs as the first test in the JVM, CloudStorageFileSystemProvider will initialize internally using all default options (which are production endpoints). This fix ensures that before the `gs://` uri is resolved in the NIOTests that LocalStorageHelper is configured rather than defaults.
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=========================================
Coverage 72.57% 72.57%
Complexity 500 500
=========================================
Files 29 29
Lines 1670 1670
Branches 276 276
=========================================
Hits 1212 1212
Misses 335 335
Partials 123 123 Continue to review full report at Codecov.
|
Neenu1995
approved these changes
May 11, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.122.14](https://www.github.com/googleapis/java-storage-nio/compare/v0.122.13...v0.122.14) (2021-05-12) ### Bug Fixes * **test:** update NIOTest to ensure LocalStorageHelper is used ([#552](https://www.github.com/googleapis/java-storage-nio/issues/552)) ([e0cd38d](https://www.github.com/googleapis/java-storage-nio/commit/e0cd38d93d5ca28207540dbdf70151010ed35c47)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.1.0 ([#550](https://www.github.com/googleapis/java-storage-nio/issues/550)) ([bf60a21](https://www.github.com/googleapis/java-storage-nio/commit/bf60a21f3b7f242961eb5d6ed215e49becf3ba9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting a test, there is a
gs://uri which is referenced before any unit test level configuration of CloudStorageFileSystemProvider. If NIOTest runs as the first test in the JVM, CloudStorageFileSystemProvider will initialize internally using all default options (which are production endpoints).This fix ensures that before the
gs://uri is resolved in the NIOTests that LocalStorageHelper is configured rather than defaults.