fix: update bucket creation to set project as bucket.project#1912
Merged
BenWhitehead merged 1 commit intomainfrom Mar 28, 2023
Merged
fix: update bucket creation to set project as bucket.project#1912BenWhitehead merged 1 commit intomainfrom
bucket.project#1912BenWhitehead merged 1 commit intomainfrom
Conversation
Creation of a bucket is modifying which field is used to specify the project a bucket is associated with. Changing from `parent` to `bucket.project`. This change updates our handling to use this new field. The existing `parent` is set to the sentinel value `projects/_` which was previously only implicitly found in the bucket name. Update testbench tag to v0.35.0 which includes the new field behavior. ApiaryConversions have been updated to track the project attribute when cross converting as the property `.x_project`; this value should avoid any possible collision if the field name project is supported in the future while the client is operating in this intervening time. If/when StorageObject receives its own project field we should switch to using it. Fix associated with b/254678990
1d24c0d to
a723d3c
Compare
JesseLovelace
approved these changes
Mar 28, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
🤖 I have created a release *beep* *boop* --- ## [2.21.0](https://togithub.com/googleapis/java-storage/compare/v2.20.2...v2.21.0) (2023-03-31) ### Features * Remove Bucket.retention_period, now that we've migrated to retention_duration ([#1955](https://togithub.com/googleapis/java-storage/issues/1955)) ([c0ffe7c](https://togithub.com/googleapis/java-storage/commit/c0ffe7c7cb50181cc375a945b9e79f97da9aa290)) ### Bug Fixes * Update bucket creation to set project as `bucket.project` ([#1912](https://togithub.com/googleapis/java-storage/issues/1912)) ([65993c0](https://togithub.com/googleapis/java-storage/commit/65993c0614987b96962ff28404de2aaea4ee679d)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.6.0 ([#1957](https://togithub.com/googleapis/java-storage/issues/1957)) ([af90f16](https://togithub.com/googleapis/java-storage/commit/af90f162ac038479a0f09fb45289b1aa258d1aec)) * Update dependency net.jqwik:jqwik to v1.7.3 ([#1944](https://togithub.com/googleapis/java-storage/issues/1944)) ([a8b96c9](https://togithub.com/googleapis/java-storage/commit/a8b96c9a2da7fbdf9de5e15e833058117570c24e)) ### Documentation * Revert ChecksummedData message definition not to specify ctype=CORD, ([#1960](https://togithub.com/googleapis/java-storage/issues/1960)) ([3a2a643](https://togithub.com/googleapis/java-storage/commit/3a2a643ff389741efaad244bbabf494dcd9a799b)) * Updated ChecksummedData message definition to specify ctype=CORD, and removed incorrect earlier attempt that set that annotation in the ReadObjectResponse message definition ([#1959](https://togithub.com/googleapis/java-storage/issues/1959)) ([3d97bdd](https://togithub.com/googleapis/java-storage/commit/3d97bddc668deb2059261260125f94c6e32aac76)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creation of a bucket is modifying which field is used to specify the project a bucket is associated with. Changing from
parenttobucket.project. This change updates our handling to use this new field.The existing
parentis set to the sentinel valueprojects/_which was previously only implicitly found in the bucket name.Update testbench tag to v0.35.0 which includes the new field behavior.
ApiaryConversions have been updated to track the project attribute when cross converting as the property
.x_project; this value should avoid any possible collision if the field name project is supported in the future while the client is operating in this intervening time. If/when StorageObject receives its own project field we should switch to using it.Fix associated with b/254678990
This PR is a preemptive fix for the change which will rollout to fix http://b/254678990