docs: document differing behavior of {get,list}{,default}Acl between HTTP and gRPC#1820
Merged
BenWhitehead merged 2 commits intomainfrom Jan 4, 2023
Merged
docs: document differing behavior of {get,list}{,default}Acl between HTTP and gRPC#1820BenWhitehead merged 2 commits intomainfrom
BenWhitehead merged 2 commits intomainfrom
Conversation
…HTTP and gRPC Update ITAccessTest to run UBLA and IAM centric tests for gRPC. Split iam v1 and iam v3 tests out from ITAccessTest to ITBucketIamPolicyTest making them hermetic.
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketIamPolicyTest.java
Outdated
Show resolved
Hide resolved
frankyn
approved these changes
Jan 4, 2023
| private static void assertPolicyEqual(Policy expected, Policy actual) throws Exception { | ||
| TestUtils.assertAll( | ||
| () -> assertThat(actual.getVersion()).isEqualTo(expected.getVersion()), | ||
| () -> assertBindingsEqual(expected.getBindingsList(), actual.getBindingsList())); |
Contributor
There was a problem hiding this comment.
IIUC, this is needed because Etags will differ between the two policies.
Collaborator
Author
There was a problem hiding this comment.
Correct, the differing etag values (or in the case of defining a policy ourselves, where there is no etag) prevents being able to depend on equals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ITAccessTest to run UBLA and IAM centric tests for gRPC. Split iam v1 and iam v3 tests out from ITAccessTest to ITBucketIamPolicyTest making them hermetic.