feat: Blob/Object get #1403
Merged
feat: Blob/Object get #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWhitehead
requested changes
May 23, 2022
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Overall looks pretty good. A few changes about base64 handling need to be addressed, but other than that looks pretty good.
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcConversions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcConversions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcConversions.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcConversions.java
Outdated
Show resolved
Hide resolved
| s -> | ||
| BaseEncoding.base64() | ||
| .encode(Hashing.md5().hashBytes(s.getBytes()).asBytes()))) | ||
| .as( |
Collaborator
There was a problem hiding this comment.
This can be done in a later PR if you feel like it.
This will need to changes from a combine of two arbitraries, to a single arbitrary which yields both crc32c and md5 values.
We want to ensure the value for those fields is generated base on the same bytes in the general case. Later we can investigate if we want to add an edge case where the md5 does not correspond to crc32c of the same input data.
Contributor
Author
There was a problem hiding this comment.
ah I see makes sense. I will look into it.
google-cloud-storage/src/test/java/com/google/cloud/storage/jqwik/StorageArbitraries.java
Show resolved
Hide resolved
BenWhitehead
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.