feat: DeleteHmacKey and HmacKeyMetadata GRPC #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWhitehead
approved these changes
May 16, 2022
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
A couple minor things, feel free to merge after addressing.
| final StringBuilder sb = new StringBuilder(); | ||
| sb.append(first).append(mid).append(last); | ||
| // can only contain lowercase letters | ||
| return new ProjectID(sb.toString().toLowerCase()); |
Collaborator
There was a problem hiding this comment.
We can actually push the lower case constraint back up to the arbitrary by doing
Arbitraries.chars().range('a', 'z').numeric()
This has the added benefit that the arbitrary is aware of the constraint and can therefore track and reduce against this.
I'll make a similar change to the arbitrary for BucketName in a separate PR.
| @Override | ||
| public Set<Arbitrary<?>> provideFor(TypeUsage targetType, SubtypeProvider subtypeProvider) { | ||
|
|
||
| @UpperChars Arbitrary<String> accessID = Arbitraries.strings().alpha().numeric().ofLength(61); |
Collaborator
There was a problem hiding this comment.
The annotation here doesn't actually effect this how we'd hope. (The annotations are useful along with the @ForAll to constrain the inputs).
To get the desired set we'd need to do something like:
Arbitrary<String> accessID = Arbitraries.strings().withCharRange('A', 'Z').numeric().ofLength(61);
Collaborator
|
Thanks for the update @JesseLovelace. Feel free to merge after rebasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at adding to GRPC, includes DeleteHmacKey operation and HmacKeyMetadata modeling + property tests.
Forgive any errors i made with property testing, i'm new here!