feat: bucket metadata #1385
Merged
feat: bucket metadata #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
848ab5d to
bbce3fd
Compare
* Introduce StorageArbitraries where we can put common arbitraries which aren't globally registered by type.
| ifNonNull(from.getLocationType(), to::setLocationType); | ||
| ifNonNull(from.getMetageneration(), to::setMetageneration); | ||
| ifNonNull(from.getBilling(), Billing::getRequesterPays, to::setRequesterPays); | ||
| ifNonNull(from.getCreateTime(), Timestamp::getSeconds, to::setCreateTime); |
Contributor
There was a problem hiding this comment.
The time values in these conversions is a bit confusing.. I believe that for BucketInfo the values should be in milliseconds but there is no option in Timestamp to set milliseconds. see https://cloud.google.com/java/docs/reference/google-cloud-storage/latest/com.google.cloud.storage.BucketInfo#com_google_cloud_storage_BucketInfo_getUpdateTime__
however update time is the only field that specifically calls out milliseconds from unix epoch.
Contributor
Author
There was a problem hiding this comment.
Good catch, we may not catch more of these until we get into integration testing.
We can use toMillis(), thanks!
9be0aad to
d15fc94
Compare
BenWhitehead
approved these changes
May 13, 2022
sydney-munro
pushed a commit
that referenced
this pull request
Jun 7, 2022
…etGetOptions...) (#1385) * Introduce StorageArbitraries to contain common arbitraries which aren't globally registered by type. Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.