docs: Adding PubSub Notification Samples#1317
Merged
sydney-munro merged 9 commits intomainfrom Mar 31, 2022
Merged
Conversation
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
|
Warning: This pull request is touching the following templated files:
|
125c5a1 to
6d92957
Compare
frankyn
suggested changes
Mar 29, 2022
samples/snippets/src/main/java/com/example/storage/bucket/DeleteBucketPubSubNotification.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/storage/bucket/ListPubSubNotifications.java
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/storage/bucket/CreateBucketPubSubNotification.java
Outdated
Show resolved
Hide resolved
044a3fd to
ddc4c5c
Compare
5ff03b3 to
584abff
Compare
4c3fd41 to
f790f1d
Compare
5ed7f2b to
9022a7c
Compare
e8acf42 to
ab6979b
Compare
5943cc4 to
ddbc554
Compare
frankyn
suggested changes
Mar 31, 2022
| Storage storage = StorageOptions.newBuilder().build().getService(); | ||
| NotificationInfo notificationInfo = | ||
| NotificationInfo.newBuilder(topicName) | ||
| .setEtag(etag) |
Contributor
There was a problem hiding this comment.
etag should be set by the service and shouldn't be set by a user directly unless performing an update request.
I would most likely leave this value out.
| NotificationInfo.newBuilder(topicName) | ||
| .setEtag(etag) | ||
| .setCustomAttributes(customAttributes) | ||
| .setSelfLink(selfLink) |
Contributor
There was a problem hiding this comment.
selfLink() should be set by the service; this field setter shouldn't need to be public.
ec70866 to
acb0115
Compare
frankyn
approved these changes
Mar 31, 2022
Contributor
frankyn
left a comment
There was a problem hiding this comment.
LGTM, thanks @sydney-munro!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issues:
storage_print_pubsub_bucket_notification b/219957979
storage_delete_bucket_notification b/219958287
storage_list_bucket_notifications b/219958499
storage_create_bucket_notifications b/219958206
If you write sample code, please follow the samples format.