feat: update all automatic retry behavior to be idempotency aware#1132
Merged
BenWhitehead merged 4 commits intogoogleapis:mainfrom Nov 2, 2021
BenWhitehead:feat-retry
Merged
feat: update all automatic retry behavior to be idempotency aware#1132BenWhitehead merged 4 commits intogoogleapis:mainfrom BenWhitehead:feat-retry
BenWhitehead merged 4 commits intogoogleapis:mainfrom
BenWhitehead:feat-retry
Conversation
tritone
approved these changes
Nov 1, 2021
Contributor
tritone
left a comment
There was a problem hiding this comment.
Can I just say how delightful it is that the PR to actually change this behavior ended up being <10 lines?
1. Add new configuration option `StorageOptions.Builder#setStorageRetryStrategy` 2. Add new interface `StorageRetryStrategy` 3. Update all calls to be made idempotency aware 4. Change default behavior of automatic retries to only retry those operations which are deemed to be idempotent 5. Add @deprecated method `StorageRetryStrategy.getLegacyStorageRetryStrategy` providing access to a strategy which matches the previous sometimes unsafe behavior
Collaborator
Author
|
Hehe, yeah the 10 lines felt great. Then the tests not setting IfGenerationMatch reared their head :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageOptions.Builder#setStorageRetryStrategyStorageRetryStrategyStorageRetryStrategy.getLegacyStorageRetryStrategyproviding access to a strategy which matches the previous sometimes unsafe behavior