test: retry conformance tests fixes, round 3#1050
Merged
BenWhitehead merged 1 commit intogoogleapis:masterfrom Sep 28, 2021
BenWhitehead:retry-conformance-tests/fixes-3
Merged
test: retry conformance tests fixes, round 3#1050BenWhitehead merged 1 commit intogoogleapis:masterfrom BenWhitehead:retry-conformance-tests/fixes-3
BenWhitehead merged 1 commit intogoogleapis:masterfrom
BenWhitehead:retry-conformance-tests/fixes-3
Conversation
Collaborator
BenWhitehead
commented
Sep 28, 2021
- add applicability predicate for setIamPolicy mappings
- add metageneration precondition mapping for setIamPolicy
- add applicability predicate for hmacKey.update mappings
- fix objects.delete mappings to use stateful blob
- fix objects.delete to use generationMatch
- add applicability predicate for objects.patch mappings
frankyn
approved these changes
Sep 28, 2021
...loud-storage/src/test/java/com/google/cloud/storage/conformance/retry/RpcMethodMappings.java
Show resolved
Hide resolved
...loud-storage/src/test/java/com/google/cloud/storage/conformance/retry/RpcMethodMappings.java
Show resolved
Hide resolved
* add applicability predicate for setIamPolicy mappings * add metageneration precondition mapping for setIamPolicy * add applicability predicate for hmacKey.update mappings * fix objects.delete mappings to use stateful blob * fix objects.delete to use generationMatch * add applicability predicate for objects.patch mappings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.