Skip to content

Conversation

@olavloite
Copy link
Collaborator

@olavloite olavloite commented Feb 24, 2022

Creates specific metadata queries for PostgreSQL dialect databases and
removes the use of the /GSQL/ header in the existing metadata queries.

Fixes #760

Creates specific metadata queries for PostgreSQL dialect databases and
removes the use of the /*GSQL*/ header in the existing metadata queries.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Feb 24, 2022
@olavloite olavloite marked this pull request as ready for review February 24, 2022 13:49
@olavloite olavloite requested review from a team as code owners February 24, 2022 13:49
@olavloite olavloite requested a review from ansh0l February 24, 2022 13:49
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. removes GSQL_STATEMENT and /*GSQL*/ comments.

@ansh0l ansh0l merged commit caffda0 into main Feb 24, 2022
@ansh0l ansh0l deleted the pg-specific-metadata-queries branch February 24, 2022 18:47
@ansh0l
Copy link
Contributor

ansh0l commented Feb 24, 2022

Merging as discussed with @olavloite

gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 24, 2022
🤖 I have created a release *beep* *boop*
---


## [2.6.0](v2.5.11...v2.6.0) (2022-02-24)


### Features

* add support for PostgreSQL dialect ([#739](#739)) ([f9daa19](f9daa19))


### Bug Fixes

* create specific metadata queries for PG ([#759](#759)) ([caffda0](caffda0))


### Dependencies

* update dependency com.google.cloud:google-cloud-spanner-bom to v6.20.0 ([#758](#758)) ([311d1ca](311d1ca))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JDBC metadata queries use /*GSQL*/ header

2 participants