This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: support DDL/ClientSideStatement through (Statement/PreparedStatement).executeUpdate API#1152
Closed
rajatbhatta wants to merge 2 commits into
Closed
fix: support DDL/ClientSideStatement through (Statement/PreparedStatement).executeUpdate API#1152rajatbhatta wants to merge 2 commits into
rajatbhatta wants to merge 2 commits into
Conversation
…ment).executeUpdate API DDL statements and ClientSideStatements which return no result are now supported through PreparedStatement.executeUpdate and Statement.executeUpdate APIs in ConnectionImpl and should return 0L in that case. Exceptions are thrown for cases where the statement is expected to return a ResultSet (for example, DML Returning statements, ClientSideStatements which return ResultSet).
olavloite
reviewed
Mar 9, 2023
olavloite
left a comment
Collaborator
There was a problem hiding this comment.
This looks generally good to me, but I'll wait with final approval until we can actually run the tests on the updated Connection API.
| * statements to be executed. It assumes that the user knows what kind of statement is being | ||
| * executed, and the method will therefore return 0 for non-returning DML statements that | ||
| * changed 0 rows and for all statements that return no result. The method throws a | ||
| * SQLException for Returning DML statements. |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| * SQLException for Returning DML statements. | |
| * SQLException for DML statements with a THEN RETURN / RETURNING clause. |
| * statements to be executed. It assumes that the user knows what kind of statement is being | ||
| * executed, and the method will therefore return 0 for non-returning DML statements that | ||
| * changed 0 rows and for all statements that return no result. The method throws a | ||
| * SQLException for Returning DML statements. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * SQLException for Returning DML statements. | |
| * SQLException for DML statements with a THEN RETURN / RETURNING clause. |
olavloite
added a commit
that referenced
this pull request
Jan 25, 2024
Verifies that client-side statements can now also be executed using the executeQuery and executeUpdate methods. Replaces #1152
Collaborator
|
Replaced by #1473 |
olavloite
added a commit
that referenced
this pull request
Feb 12, 2024
Verifies that client-side statements can now also be executed using the executeQuery and executeUpdate methods. Replaces #1152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDL statements and ClientSideStatements which return no result are now supported through PreparedStatement.executeUpdate and Statement.executeUpdate APIs in ConnectionImpl and should return 0L in that case.
Exceptions are thrown for cases where the statement is expected to return a ResultSet (for example, DML Returning statements, ClientSideStatements which return ResultSet).
These changes are made on top of changes in googleapis/java-spanner#2324. So, integration tests may not pass until those changes are merged and released.