-
Notifications
You must be signed in to change notification settings - Fork 52
Description
While troubleshooting #251 (comment), I found the pom.xml of this repository imports the Libraries BOM. (Since when? The PR #133 in May 2020 added the Libraries BOM in this project's pom.xml through dependencyManagement section's import. It seems that the PR intended to make it easy to specify the versions of multiple libraries.)
However, the Libraries BOM includes this repository's library (com.google.cloud:google-cloud-spanner-jdbc) through google-cloud-bom. It's a circular dependency. This circular dependency makes dependency troubleshooting difficult in #251 .
Shall we use the shared dependency BOM only and remove the libraries BOM from the dependency management section?
Here is removal of the library versions from pom.xml: https://github.com/googleapis/java-spanner-jdbc/pull/133/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R59
- grpc.version
- api-client.version
- google.core.version
- gax.version
- http-client-bom.version
- guava.version
- google.common-protos.version
- protobuf.version
- google.api-common.version
- spanner.version
- google.auth.version