refactor: use Connection API in client lib #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic Connection API has been moved to the client library. The JDBC driver still contained its own copy of this API. This change removes this own API and instead uses the one in the client library.
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 77.92% 71.95% -5.97%
+ Complexity 1732 1027 -705
============================================
Files 60 24 -36
Lines 5911 3156 -2755
Branches 835 463 -372
============================================
- Hits 4606 2271 -2335
+ Misses 928 706 -222
+ Partials 377 179 -198
Continue to review full report at Codecov.
|
skuruppu
approved these changes
May 27, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic Connection API has been moved to the client library. The JDBC driver still contained its own copy of this API. This change removes this own API and instead uses the one in the client library.
This also changes the dependency management of the JDBC driver from self-management into using the
com.gooble.cloud.libraries-bom.