Skip to content

Conversation

@olavloite
Copy link
Collaborator

@olavloite olavloite commented Dec 11, 2020

This change reduces the number of administrative requests that are executed by the samples integration tests, in order to prevent (or at least reduce) RESOURCE_EXHAUSTED errors caused by exceeding the administrative requests limit.

@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Dec 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #717 (57bc233) into master (f14f7c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #717   +/-   ##
=========================================
  Coverage     85.03%   85.03%           
- Complexity     2553     2554    +1     
=========================================
  Files           142      142           
  Lines         13930    13930           
  Branches       1326     1326           
=========================================
  Hits          11846    11846           
  Misses         1527     1527           
  Partials        557      557           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14f7c9...57bc233. Read the comment docs.

@olavloite olavloite marked this pull request as ready for review December 11, 2020 19:42
@olavloite olavloite requested a review from a team as a code owner December 11, 2020 19:42
@olavloite olavloite requested a review from a team December 11, 2020 19:42
@olavloite olavloite changed the title [WIP] test: reduce administrative calls in samples test: reduce administrative calls in samples Dec 11, 2020
@thiagotnunes thiagotnunes merged commit e3257e8 into master Dec 13, 2020
@thiagotnunes thiagotnunes deleted the reduce-admin-requests branch December 13, 2020 22:52
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5119

Changes:

feat(osconfig): Update OSConfig API
  PiperOrigin-RevId: 409204961
  Source-Link: googleapis/googleapis@a85beae

chore(bazel): update gapic-generator-go v0.23.3
  PiperOrigin-RevId: 409194656
  Source-Link: googleapis/googleapis@2bea4df

feat(dialogflow): support document metadata filter in article suggestion and smart reply model in human agent assistant
  PiperOrigin-RevId: 409190373
  Source-Link: googleapis/googleapis@29bb98c

chore: regenerate API index

  Source-Link: googleapis/googleapis@c522fe8

feat: VM Migration API
  PiperOrigin-RevId: 409184793
  Source-Link: googleapis/googleapis@5e57bed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants