test: check that page actually contains an element #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test wrongly assumed that if the previous page returned a nextPageToken that the next call would always contain exactly one more result. It is however possible that the result that had not yet been returned was deleted by another process in the meantime, which would cause the next page to be empty. Fixes #570
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
============================================
- Coverage 84.05% 84.03% -0.02%
+ Complexity 2503 2502 -1
============================================
Files 141 141
Lines 13806 13806
Branches 1317 1317
============================================
- Hits 11604 11602 -2
- Misses 1656 1657 +1
- Partials 546 547 +1
Continue to review full report at Codecov.
|
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#3892 Changes: fix!: remove empty appengine/v1beta/deployed_files.proto PiperOrigin-RevId: 366869955 Source-Link: googleapis/googleapis@fa7915f chore(bazel): update rules_gapic to v0.5.3 PiperOrigin-RevId: 366838867 Source-Link: googleapis/googleapis@d78dc2e chore: upgrade gapic-generator-python to 0.43.2 PiperOrigin-RevId: 366826395 Source-Link: googleapis/googleapis@2490be3 feat(bigquery/storage): deprecate bigquery storage v1alpha2 API Committer: @yirutang PiperOrigin-RevId: 366823379 Source-Link: googleapis/googleapis@1a7d764
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test wrongly assumed that if the previous page returned a
nextPageTokenthat the next call would always contain exactly one more result. It is however possible that the result that had not yet been returned was deleted by another process in the meantime, which would cause the next page to be empty.Fixes #570