refactor: use RpcPriority internally in the Connection API #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Connection API used the (proto) enum Priority internally, while the actual connection property uses the public-facing `com.google.cloud.spanner.RpcPriority` in public APIs. This change modifies the internal parser to also directly use the public-facing enum, instead of going through the proto enum definition first, only to translate to the public enum at a later moment.
rahul2393
approved these changes
Sep 10, 2024
lqiu96
pushed a commit
that referenced
this pull request
Sep 19, 2024
The Connection API used the (proto) enum Priority internally, while the actual connection property uses the public-facing `com.google.cloud.spanner.RpcPriority` in public APIs. This change modifies the internal parser to also directly use the public-facing enum, instead of going through the proto enum definition first, only to translate to the public enum at a later moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Connection API used the (proto) enum Priority internally, while the actual connection property uses the public-facing
com.google.cloud.spanner.RpcPriorityin public APIs. This change modifies the internal parser to also directly use the public-facing enum, instead of going through the proto enum definition first, only to translate to the public enum at a later moment.