Skip to content

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yangnuoyu wants to merge 1 commit into from
Closed

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies #284

yangnuoyu wants to merge 1 commit into from

Conversation

@yangnuoyu
Copy link
Contributor

@yangnuoyu yangnuoyu commented Jun 19, 2020 •
edited
Loading

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2020
@yangnuoyu yangnuoyu marked this pull request as ready for review June 23, 2020 04:40
@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Jun 23, 2020

@olavloite could you take a look at the IT failure?

expected: 20
but was : 8
	at com.google.cloud.spanner.it.ITSpannerOptionsTest.testCloseAllThreadsWhenClosingSpanner(ITSpannerOptionsTest.java:105)

@olavloite
Copy link
Collaborator

olavloite commented Jun 24, 2020

@olavloite could you take a look at the IT failure?

expected: 20
but was : 8
	at com.google.cloud.spanner.it.ITSpannerOptionsTest.testCloseAllThreadsWhenClosingSpanner(ITSpannerOptionsTest.java:105)

This failure is caused by the changed that is introduced in googleapis/gax-java@cf1bce8

Spanner sets an ExecutorProvider on the TransportChannelProvider. Previously, this meant that an executor would be requested for each channel that was created by the TransportChannelProvider. The setExecutorProvider has now been deprecated and its implementation has been changed to get one Executor to use for all channels, instead of requesting one Executor for each channel. That again means that there are now a lot less threads available for the transport channels than before. I wonder whether that was an intentional part of the change, or more of a side-effect of the change.

I think that we need to add some code changes when upgrading to this latest version to mitigate for this. Otherwise the entire Spanner library will only have 4 threads available for all transport channels for both all the data clients as well as the admin clients.

@olavloite olavloite mentioned this pull request Jun 24, 2020
Merged
@olavloite
Copy link
Collaborator

olavloite commented Jun 24, 2020

Superseded by #302

@olavloite olavloite closed this Jun 24, 2020
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@olavloite @yoshi-code-bot
feat: allow unknown properties in connection url with lenient mode (g…
0e557ef 
…oogleapis#284)

* feat: allow unknown properties in connection url with lenient mode

* Update src/test/java/com/google/cloud/spanner/jdbc/JdbcDriverTest.java

Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>

* fix: add credentials to prevent the use of env credentials

Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite Awaiting requested review from olavloite

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yangnuoyu @stephaniewang526 @olavloite @googlebot