Skip to content

Conversation

@olavloite
Copy link
Collaborator

The SpannerRetryHelperTest.testExceptionWithRetryInfo could still fail on Windows. Some more digging seems to indicate that this is a known bug in the accuracy of the Thread.sleep(long) method on Windows.

See https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6435126 and https://stackoverflow.com/questions/824110/accurate-sleep-for-java-on-windows

Fixes #257

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
@olavloite olavloite requested a review from skuruppu June 11, 2020 19:24
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@skuruppu skuruppu merged commit f89da6a into master Jun 12, 2020
@skuruppu skuruppu deleted the workaround-windows-sleep-bug branch June 12, 2020 05:23
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
…s#266)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/268ed0db-90ce-4f9f-ba46-1924fe46218f/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@7db8a6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: SpannerRetryHelperTest.testExceptionWithRetryInfo failure

3 participants