samples: add support for BatchWriteAtLeastOnce #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
arpan14
reviewed
Aug 24, 2023
samples/snippets/src/main/java/com/example/spanner/BatchWriteAtLeastOnceSample.java
Outdated
Show resolved
Hide resolved
arpan14
approved these changes
Aug 25, 2023
olavloite
reviewed
Aug 28, 2023
samples/snippets/src/main/java/com/example/spanner/BatchWriteAtLeastOnceSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/BatchWriteAtLeastOnceSample.java
Outdated
Show resolved
Hide resolved
olavloite
reviewed
Oct 3, 2023
| * Assume DDL for the underlying database: | ||
| * <pre>{@code | ||
| * CREATE TABLE Singers ( | ||
| * SingerId INT64 NOT NULL, |
Collaborator
There was a problem hiding this comment.
nit: add a couple of spaces for indentation
| projectId, instanceId, databaseId)); | ||
| assertTrue( | ||
| out.contains("have been applied with commit timestamp") | ||
| || out.contains("could not be applied with error code")); |
Collaborator
There was a problem hiding this comment.
We don't expect an error here, do we? So in that case I think we should let the test case fail with the error instead of letting the test pass here.
If it is possible that the call fails with a transient error (e.g. UNAVAILABLE or ABORTED), then I think that the sample should show how customers should handle that.
Contributor
There was a problem hiding this comment.
Yeah I agree we should exclude out.contains("could not be applied with error code") and let the test case fail. Modified this.
olavloite
approved these changes
Oct 3, 2023
surbhigarg92
pushed a commit
to surbhigarg92/java-spanner
that referenced
this pull request
Oct 5, 2023
* samples: add support for BatchWriteAtleastOnce * samples: add support for BatchWriteAtleastOnce * samples: add support for BatchWriteAtleastOnce * modify sample based on new design * remove host * chore: review comments. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: fix review comments. --------- Co-authored-by: Arpan Mishra <akmish3@gmail.com> Co-authored-by: Arpan Mishra <arpanmishra@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Github checks are expected to fail until #2520 is released, and a new
libraries-bomversion is out.