Skip to content

refactor: remove local variables, use static constants #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rajatbhatta merged 2 commits into from
Mar 17, 2023
Merged

refactor: remove local variables, use static constants #2322

rajatbhatta merged 2 commits into from
Mar 17, 2023

Conversation

@orischwartz
Copy link
Contributor

@orischwartz orischwartz commented Mar 6, 2023

these are defined in the base class AbstractStatementParser:

java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/AbstractStatementParser.java

Lines 475 to 486 in 30a32e9

static final char SINGLE_QUOTE = '\'';
static final char DOUBLE_QUOTE = '"';
static final char BACKTICK_QUOTE = '`';
static final char HYPHEN = '-';
static final char DASH = '#';
static final char SLASH = '/';
static final char ASTERISK = '*';
static final char DOLLAR = '$';
static final char SPACE = ' ';
static final char CLOSE_PARENTHESIS = ')';
static final char COMMA = ',';
static final char UNDERSCORE = '_';

@orischwartz orischwartz requested a review from a team as a code owner March 6, 2023 17:08
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 6, 2023
@rajatbhatta
Copy link
Contributor

rajatbhatta commented Mar 7, 2023

@orischwartz: Thank you for raising the PR to Cloud Spanner Java Client. Can you please add the commit using conventionalcommits.org conventions?

Something like:
refactor: remove local variables, use static constants

@orischwartz
refactor: remove local variables, use constants
8e0bf58 
These are already defined in the base class AbstractStatementParser
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner March 16, 2023 09:45
@rajatbhatta rajatbhatta changed the title Remove local variables, use static constants refactor: remove local variables, use static constants Mar 16, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2023
@rajatbhatta rajatbhatta merged commit b98c594 into googleapis:main Mar 17, 2023
arpan14 pushed a commit to arpan14/java-spanner that referenced this pull request Apr 28, 2023
@orischwartz @gcf-owl-bot @arpan14
refactor: remove local variables, use static constants (googleapis#2322)
3fa15cb 
* refactor: remove local variables, use constants

These are already defined in the base class AbstractStatementParser

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orischwartz @rajatbhatta @yoshi-kokoro