feat: add explicit duplicate subscriber handling to SubscriberImpl for beam #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r beam Beam needs a way to know that a <subscription, partition> has been relocated to another worker, and provides no in-model way to do this. We can reuse the duplicate connection error to detect occurences of this and respect them.
tmdiep
approved these changes
Mar 14, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.12...v1.5.0) (2022-03-16) ### Features * add explicit duplicate subscriber handling to SubscriberImpl for beam ([#1088](#1088)) ([f808056](f808056)) ### Dependencies * update dependency com.google.cloud:google-cloud-bom to v0.171.0 ([#1085](#1085)) ([88551c6](88551c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beam needs a way to know that a <subscription, partition> has been relocated to another worker, and provides no in-model way to do this. We can reuse the duplicate connection error to detect occurences of this and respect them.