Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 26, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Mar 26, 2025
@diegomarquezp diegomarquezp force-pushed the demo-templates-fix-202503 branch from 9b6aff7 to 1b4366c Compare March 27, 2025 19:06
@diegomarquezp diegomarquezp force-pushed the demo-templates-fix-202503 branch from 1b4366c to 162f840 Compare March 28, 2025 16:12
diegomarquezp added a commit to googleapis/sdk-platform-java that referenced this pull request Apr 7, 2025
…neration (#3723)

Part of the fix for
#3701 ☕

### Approach
The templates come from
https://github.com/googleapis/synthtool/tree/bf182cd41d9a7de56092cafcc7befe6b398332f6.
The only update was to include `generated-files-bot`, which is already
up to date in all the HW repos.

The `.kokoro` folder will be a separate follow up task. We will now
focus on solving the update of `update_generation_config` `yaml` and
`sh` files.

The fix to include the `.github` folder follows from
https://setuptools.pypa.io/en/latest/userguide/datafiles.html:
```
Glob patterns do not automatically match dotfiles, i.e., directory or file names starting with a dot (.).
To include such files, you must explicitly start the pattern with a dot, e.g. .* to match .gitignore.
```


Interestingly, this is also the reason `cp
synthool/gcp/templates/java_library/* ...` did not bring folders
starting with dot (such as .kokoro) into
#2884
### Confirming effects in downstream repos
Demos show the results as of
b66af92
in
 - googleapis/java-storage#3012
 - googleapis/java-logging#1787
 - googleapis/java-pubsub#2384
 - googleapis/java-bigtable#2546
 - googleapis/java-spanner#3711
 - googleapis/java-firestore#2065
 - googleapis/java-datastore#1810
 - googleapis/java-bigquerystorage#2929
 - googleapis/java-pubsublite#1837

There were no regressions on templated files that were manually
modified.
lqiu96 pushed a commit to googleapis/sdk-platform-java that referenced this pull request Jun 10, 2025
…neration (#3723)

Part of the fix for
#3701 ☕

### Approach
The templates come from
https://github.com/googleapis/synthtool/tree/bf182cd41d9a7de56092cafcc7befe6b398332f6.
The only update was to include `generated-files-bot`, which is already
up to date in all the HW repos.

The `.kokoro` folder will be a separate follow up task. We will now
focus on solving the update of `update_generation_config` `yaml` and
`sh` files.

The fix to include the `.github` folder follows from
https://setuptools.pypa.io/en/latest/userguide/datafiles.html:
```
Glob patterns do not automatically match dotfiles, i.e., directory or file names starting with a dot (.).
To include such files, you must explicitly start the pattern with a dot, e.g. .* to match .gitignore.
```


Interestingly, this is also the reason `cp
synthool/gcp/templates/java_library/* ...` did not bring folders
starting with dot (such as .kokoro) into
#2884
### Confirming effects in downstream repos
Demos show the results as of
b66af92
in
 - googleapis/java-storage#3012
 - googleapis/java-logging#1787
 - googleapis/java-pubsub#2384
 - googleapis/java-bigtable#2546
 - googleapis/java-spanner#3711
 - googleapis/java-firestore#2065
 - googleapis/java-datastore#1810
 - googleapis/java-bigquerystorage#2929
 - googleapis/java-pubsublite#1837

There were no regressions on templated files that were manually
modified.
lqiu96 pushed a commit to googleapis/sdk-platform-java that referenced this pull request Aug 21, 2025
…neration (#3723)

Part of the fix for
#3701 ☕

### Approach
The templates come from
https://github.com/googleapis/synthtool/tree/bf182cd41d9a7de56092cafcc7befe6b398332f6.
The only update was to include `generated-files-bot`, which is already
up to date in all the HW repos.

The `.kokoro` folder will be a separate follow up task. We will now
focus on solving the update of `update_generation_config` `yaml` and
`sh` files.

The fix to include the `.github` folder follows from
https://setuptools.pypa.io/en/latest/userguide/datafiles.html:
```
Glob patterns do not automatically match dotfiles, i.e., directory or file names starting with a dot (.).
To include such files, you must explicitly start the pattern with a dot, e.g. .* to match .gitignore.
```


Interestingly, this is also the reason `cp
synthool/gcp/templates/java_library/* ...` did not bring folders
starting with dot (such as .kokoro) into
#2884
### Confirming effects in downstream repos
Demos show the results as of
b66af92
in
 - googleapis/java-storage#3012
 - googleapis/java-logging#1787
 - googleapis/java-pubsub#2384
 - googleapis/java-bigtable#2546
 - googleapis/java-spanner#3711
 - googleapis/java-firestore#2065
 - googleapis/java-datastore#1810
 - googleapis/java-bigquerystorage#2929
 - googleapis/java-pubsublite#1837

There were no regressions on templated files that were manually
modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant