Skip to content

samples: DEFAULT_REQUEST_BYTES_THRESHOLD default #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anguillanneuf merged 2 commits into from
Feb 15, 2022
Merged

samples: DEFAULT_REQUEST_BYTES_THRESHOLD default #1019

anguillanneuf merged 2 commits into from
Feb 15, 2022

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Feb 14, 2022

Matching defaults in sample comments with real defaults in the client library.

java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Lines 657 to 659 in 3709b2e

static final long DEFAULT_ELEMENT_COUNT_THRESHOLD = 100L;
static final long DEFAULT_REQUEST_BYTES_THRESHOLD = 1000L; // 1 kB
static final Duration DEFAULT_DELAY_THRESHOLD = Duration.ofMillis(1);

java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Lines 666 to 674 in 3709b2e

static final BatchingSettings DEFAULT_BATCHING_SETTINGS =
BatchingSettings.newBuilder()
.setDelayThreshold(DEFAULT_DELAY_THRESHOLD)
.setRequestByteThreshold(DEFAULT_REQUEST_BYTES_THRESHOLD)
.setElementCountThreshold(DEFAULT_ELEMENT_COUNT_THRESHOLD)
.setFlowControlSettings(
FlowControlSettings.newBuilder()
.setLimitExceededBehavior(FlowController.LimitExceededBehavior.Ignore)
.build())

@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Feb 14, 2022
@anguillanneuf anguillanneuf requested review from a team and mmicatka February 14, 2022 22:59
mmicatka
mmicatka approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@mmicatka mmicatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anguillanneuf anguillanneuf merged commit 0c452aa into main Feb 15, 2022
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch February 15, 2022 16:47
rajanya-google pushed a commit to rajanya-google/java-pubsub that referenced this pull request Feb 16, 2022
@anguillanneuf @rajanya-google
samples: DEFAULT_REQUEST_BYTES_THRESHOLD default (googleapis#1019)
99c4570 
* samples: DEFAULT_REQUEST_BYTES_THRESHOLD default

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmicatka mmicatka mmicatka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eaball35 eaball35

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anguillanneuf @mmicatka @eaball35