fix: update dead link #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
daniel-sanche
previously requested changes
May 18, 2021
README.md
Outdated
| Java is a registered trademark of Oracle and/or its affiliates. | ||
|
|
||
| [product-docs]: https://cloud.google.com/logging-logback/docs/ | ||
| [product-docs]: https://cloud.google.com/logging/setup/java/ |
Contributor
There was a problem hiding this comment.
This appears to be a 404. Should it be https://cloud.google.com/logging/docs/setup/java?
freelerobot
approved these changes
May 19, 2021
Contributor
freelerobot
left a comment
There was a problem hiding this comment.
LGTM
I dont think this file will be overwritten given :
java-logging-logback/synth.metadata
Line 18 in 0a1087f
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.121.0](https://www.github.com/googleapis/java-logging-logback/compare/v0.120.8...v0.121.0) (2021-06-01) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#418](https://www.github.com/googleapis/java-logging-logback/issues/418)) ([1900bbe](https://www.github.com/googleapis/java-logging-logback/commit/1900bbef7f000652d57d47a1110ad820ad42f86a)) ### Bug Fixes * update dead link ([#414](https://www.github.com/googleapis/java-logging-logback/issues/414)) ([2ff2886](https://www.github.com/googleapis/java-logging-logback/commit/2ff2886c11a13c223a5c7b114ccb7c7d189c41dd)) ### Dependencies * update dependency com.google.cloud:google-cloud-logging to v2.3.0 ([#425](https://www.github.com/googleapis/java-logging-logback/issues/425)) ([788d46a](https://www.github.com/googleapis/java-logging-logback/commit/788d46a437f2e8ea1b7c1869c243051fd98a3f95)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.2.0 ([#415](https://www.github.com/googleapis/java-logging-logback/issues/415)) ([d5e79c8](https://www.github.com/googleapis/java-logging-logback/commit/d5e79c88e575234f837a933e5e1e5305b74eff4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393 ☕️