Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Reference libraries-bom in docs#13

Merged
elharo merged 2 commits into
googleapis:masterfrom
athakor:logging-6668
Nov 7, 2019
Merged

Reference libraries-bom in docs#13
elharo merged 2 commits into
googleapis:masterfrom
athakor:logging-6668

Conversation

@athakor

@athakor athakor commented Nov 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

towards 6668

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2019
@codecov

codecov Bot commented Nov 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #13 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
+ Coverage     76.24%   76.56%   +0.31%     
+ Complexity      571      519      -52     
============================================
  Files            42       42              
  Lines          3334     3234     -100     
  Branches        232      223       -9     
============================================
- Hits           2542     2476      -66     
+ Misses          647      632      -15     
+ Partials        145      126      -19
Impacted Files Coverage Δ Complexity Δ
...loud/logging/v2/stub/GrpcLoggingServiceV2Stub.java 88.79% <0%> (-0.81%) 10% <0%> (-1%)
...loud/logging/v2/stub/GrpcMetricsServiceV2Stub.java 91.66% <0%> (-0.59%) 11% <0%> (-1%)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.45% <0%> (-0.45%) 61% <0%> (-12%)
...cloud/logging/v2/stub/GrpcConfigServiceV2Stub.java 94.85% <0%> (-0.42%) 16% <0%> (-1%)
.../logging/v2/stub/MetricsServiceV2StubSettings.java 81.81% <0%> (-0.41%) 15% <0%> (-1%)
.../logging/v2/stub/LoggingServiceV2StubSettings.java 77.98% <0%> (-0.4%) 15% <0%> (-1%)
...d/logging/v2/stub/ConfigServiceV2StubSettings.java 83.16% <0%> (-0.33%) 20% <0%> (-1%)
...c/main/java/com/google/cloud/logging/SinkInfo.java 81.92% <0%> (-0.11%) 17% <0%> (-2%)
...ain/java/com/google/cloud/logging/HttpRequest.java 91.44% <0%> (-0.05%) 44% <0%> (-12%)
...gle/cloud/logging/testing/RemoteLoggingHelper.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950ca2c...434a88b. Read the comment docs.

@athakor athakor requested review from chingor13 and elharo November 7, 2019 09:56
@elharo elharo merged commit 481978a into googleapis:master Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@athakor @elharo @googlebot