Skip to content

fix: add pojo support #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thebrianchen merged 1 commit into from
Jun 19, 2020
Merged

fix: add pojo support #265

thebrianchen merged 1 commit into from
Jun 19, 2020

Conversation

@thebrianchen
Copy link

@thebrianchen thebrianchen commented Jun 19, 2020

No description provided.

@thebrianchen thebrianchen self-assigned this Jun 19, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020 •
edited
Loading

Codecov Report

Merging #265 into bc/bulk-master will decrease coverage by 0.17%.
The diff coverage is 70.16%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             bc/bulk-master     #265      +/-   ##
====================================================
- Coverage             73.72%   73.55%   -0.18%     
- Complexity             1087     1088       +1     
====================================================
  Files                    67       67              
  Lines                  5866     5883      +17     
  Branches                642      642              
====================================================
+ Hits                   4325     4327       +2     
- Misses                 1341     1356      +15     
  Partials                200      200
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/firestore/BulkWriterOptions.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/com/google/cloud/firestore/FirestoreImpl.java 78.19% <50.00%> (ø) 25.00 <1.00> (ø)
...in/java/com/google/cloud/firestore/BulkWriter.java 64.24% <64.24%> (-5.88%) 26.00 <26.00> (ø)
...java/com/google/cloud/firestore/UpdateBuilder.java 95.00% <93.10%> (ø) 75.00 <17.00> (ø)
...n/java/com/google/cloud/firestore/RateLimiter.java 100.00% <100.00%> (ø) 13.00 <1.00> (ø)
...n/java/com/google/cloud/firestore/Transaction.java 97.56% <100.00%> (ø) 11.00 <1.00> (ø)
...in/java/com/google/cloud/firestore/WriteBatch.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...n/java/com/google/cloud/firestore/WriteResult.java 50.00% <100.00%> (ø) 4.00 <1.00> (ø)
...a/com/google/cloud/firestore/BatchWriteResult.java 100.00% <0.00%> (ø) 4.00% <0.00%> (+1.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b76565...d9696a4. Read the comment docs.

@thebrianchen thebrianchen merged commit 7286caf into bc/bulk-master Jun 19, 2020
@thebrianchen thebrianchen deleted the bc/bulk-pojo branch June 19, 2020 15:00
BenWhitehead pushed a commit that referenced this pull request Aug 7, 2020
@BenWhitehead
fix: add pojo support (#265)
0e56048
BenWhitehead pushed a commit that referenced this pull request Aug 7, 2020
@BenWhitehead
fix: add pojo support (#265)
115a184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thebrianchen thebrianchen

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thebrianchen @schmidt-sebastian @googlebot