Skip to content

samples: fix beam samples to run from command line #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Aug 25, 2022
Merged

samples: fix beam samples to run from command line #1017

gcf-merge-on-green merged 2 commits into from
Aug 25, 2022

Conversation

@kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Aug 18, 2022

No description provided.

@kolea2 kolea2 requested review from a team as code owners August 18, 2022 16:46
@generated-files-bot
Copy link

generated-files-bot bot commented Aug 18, 2022

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples. labels Aug 18, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit f697058 into googleapis:main Aug 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2022
@kolea2 kolea2 deleted the beam-sample-fixes branch August 25, 2022 17:20
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@kolea2 @cherylEnkidu
samples: fix beam samples to run from command line (#1017)
a51d5ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljbruce danieljbruce danieljbruce approved these changes

+1 more reviewer

@Shabirmean Shabirmean Shabirmean approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Shabirmean Shabirmean

Labels

api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolea2 @Shabirmean @danieljbruce