This repository was archived by the owner on Sep 16, 2023. It is now read-only.
samples: fixing machine type for new default image#490
Merged
Conversation
dzliergaard
approved these changes
Mar 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
============================================
+ Coverage 75.52% 78.19% +2.66%
- Complexity 534 606 +72
============================================
Files 48 48
Lines 4552 4402 -150
Branches 48 48
============================================
+ Hits 3438 3442 +4
+ Misses 1076 912 -164
- Partials 38 48 +10 Continue to review full report at Codecov.
|
dzlier-gcp
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataproc 2.0 is the new default image which does not support n1-standard-1. Sample corrects for this.
Fixes https://github.com/googleapis/java-dataproc/issues/485, https://github.com/googleapis/java-dataproc/issues/486, https://github.com/googleapis/java-dataproc/issues/487