Catch and log exceptions in Watchdog runnable to ensure it never stops running #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
After this is approved, I will also copy the changes over to https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/rpc/Watchdog.java#L114 |
Contributor
Author
...re-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/io/Watchdog.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
May 12, 2020
Collaborator
igorbernstein2
left a comment
There was a problem hiding this comment.
lgtm. But please backport this to the bigtable-1x branch as well
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
============================================
- Coverage 62.34% 62.34% -0.01%
- Complexity 1636 1637 +1
============================================
Files 200 200
Lines 10129 10134 +5
Branches 1035 1035
============================================
+ Hits 6315 6318 +3
- Misses 3351 3353 +2
Partials 463 463
Continue to review full report at Codecov.
|
Contributor
Author
|
@googlebot rescan |
justinuang
added a commit
to justinuang/java-bigtable-hbase
that referenced
this pull request
May 12, 2020
…s running (googleapis#2529) * Catch and log all exceptions in Watchdog runnable to ensure it never stops running See https://stackoverflow.com/questions/6894595/scheduledexecutorservice-exception-handling for details * runUnsafe
igorbernstein2
pushed a commit
that referenced
this pull request
May 12, 2020
…s running (#2529) (#2531) * Catch and log all exceptions in Watchdog runnable to ensure it never stops running See https://stackoverflow.com/questions/6894595/scheduledexecutorservice-exception-handling for details * runUnsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://stackoverflow.com/questions/6894595/scheduledexecutorservice-exception-handling for details
Fixes #2528 ☕️