feat: attempt DirectPath by default#544
Merged
kolea2 merged 2 commits intogoogleapis:masterfrom Dec 3, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
============================================
+ Coverage 81.26% 81.30% +0.04%
+ Complexity 1129 1128 -1
============================================
Files 106 106
Lines 7045 7040 -5
Branches 370 368 -2
============================================
- Hits 5725 5724 -1
+ Misses 1121 1119 -2
+ Partials 199 197 -2
Continue to review full report at Codecov.
|
kolea2
reviewed
Dec 1, 2020
Contributor
kolea2
left a comment
There was a problem hiding this comment.
This looks good but we can't merge/release until the shared dependencies BOM is released with the updated gax version. Adding do not merge label for now
kolea2
approved these changes
Dec 3, 2020
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Dec 3, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.19.0](https://www.github.com/googleapis/java-bigtable/compare/v1.18.1...v1.19.0) (2020-12-03) ### Features * attempt DirectPath by default ([#544](https://www.github.com/googleapis/java-bigtable/issues/544)) ([2043063](https://www.github.com/googleapis/java-bigtable/commit/20430636f10445e32834f44b902dd506b0bdadf8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this pull request
Mar 13, 2021
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this pull request
Mar 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.19.0](https://www.github.com/googleapis/java-bigtable/compare/v1.18.1...v1.19.0) (2020-12-03) ### Features * attempt DirectPath by default ([googleapis#544](https://www.github.com/googleapis/java-bigtable/issues/544)) ([2043063](https://www.github.com/googleapis/java-bigtable/commit/20430636f10445e32834f44b902dd506b0bdadf8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR #467 is revered in #520. Since the bug has been fixed (googleapis/gax-java#1250) and issue has been closed (grpc/grpc-java#7604), we should make the bigtable client attempt DirectPath by default again.