Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: migrate internal metrics to use bigtable_client monitored resource#2544

Merged
igorbernstein2 merged 2 commits into
mainfrom
internal-metrics-2
Mar 26, 2025
Merged

chore: migrate internal metrics to use bigtable_client monitored resource#2544
igorbernstein2 merged 2 commits into
mainfrom
internal-metrics-2

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

This unifies the k8s_container & gce_instance monitored resources. In addition it adds some client specific attributes on the new monitored resource to make it easier to debug customer issues

Change-Id: Ic0a3b2efeb486a82dab53028ee524fe473a619ad

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

…urce

This unifies the k8s_container & gce_instance monitored resources. In addition it adds some client specific attributes on the new monitored resource to make it easier to debug customer issues

Change-Id: Ic0a3b2efeb486a82dab53028ee524fe473a619ad
@igorbernstein2 igorbernstein2 requested review from a team March 25, 2025 21:29
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 25, 2025
Change-Id: I3ed6bd6f3dd678ed474b8a9a5daf3d68626b7569
@igorbernstein2 igorbernstein2 merged commit 522fb8c into main Mar 26, 2025
@igorbernstein2 igorbernstein2 deleted the internal-metrics-2 branch March 26, 2025 15:41
andre-sampaio pushed a commit to andre-sampaio/java-bigtable that referenced this pull request Apr 24, 2025
…urce (googleapis#2544)

* chore: migrate internal metrics to use bigtable_client monitored resource

This unifies the k8s_container & gce_instance monitored resources. In addition it adds some client specific attributes on the new monitored resource to make it easier to debug customer issues

Change-Id: Ic0a3b2efeb486a82dab53028ee524fe473a619ad

* fix test

Change-Id: I3ed6bd6f3dd678ed474b8a9a5daf3d68626b7569
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants