Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: create a separate otel instance for internal metrics#2522

Merged
igorbernstein2 merged 5 commits into
mainfrom
internal-metrics-1b
Mar 25, 2025
Merged

chore: create a separate otel instance for internal metrics#2522
igorbernstein2 merged 5 commits into
mainfrom
internal-metrics-1b

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

Building on #2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource

Changes:

  • create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters)
  • create internal metrics as part of BigtableClientContext creation
  • split off internal views

Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Building on #2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource

Changes:
- create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters)
- create internal metrics as part of BigtableClientContext creation
- split off internal views

Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 13, 2025
@igorbernstein2 igorbernstein2 marked this pull request as ready for review March 13, 2025 21:50
@igorbernstein2 igorbernstein2 requested review from a team March 13, 2025 21:50
Change-Id: Ia28cb95408ecf7e8ab785c5f54c0149388df202a
Change-Id: I9f99e1a0f75f1337d09ba3833fe7833e03818519
Change-Id: I3376b36bf41c9395b4fcd62c7905312dd2c3a6c9
@igorbernstein2 igorbernstein2 merged commit 4a51556 into main Mar 25, 2025
@igorbernstein2 igorbernstein2 deleted the internal-metrics-1b branch March 25, 2025 20:58
andre-sampaio pushed a commit to andre-sampaio/java-bigtable that referenced this pull request Apr 24, 2025
…is#2522)

* chore: create a separate otel instance for internal metrics

Building on googleapis#2515, this creates a private instance of otel for internal metrics. This is necessary for a follow up pr that will introduce a new internal monitored resource

Changes:
- create a separate setting for disabling internal metrics (since internal metrics will not support customer provided exporters)
- create internal metrics as part of BigtableClientContext creation
- split off internal views

Change-Id: Iaafc327f3f008bcc29510594210e0914342f84fe

* fix typo

Change-Id: Ia28cb95408ecf7e8ab785c5f54c0149388df202a

* try to deflake the metrics test again

Change-Id: I9f99e1a0f75f1337d09ba3833fe7833e03818519

* improve comment

Change-Id: I3376b36bf41c9395b4fcd62c7905312dd2c3a6c9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants