This repository was archived by the owner on May 8, 2026. It is now read-only.
fix: Add known conformance test failures#2474
Merged
Merged
Conversation
mutianf
approved these changes
Jan 29, 2025
mutianf
suggested changes
Jan 30, 2025
| @@ -1 +1 @@ | |||
|
|
|||
| TestFeatureGap/(traffic_director_enabled|direct_access_requested) | |||
Contributor
There was a problem hiding this comment.
Actually this format is incorrect.. should be:
TestFeatureGap/traffic_director_enabled|
TestFeatureGap/direct_access_requested
| # If there is known failures, please add | ||
| # "-skip `cat ../../test-proxy/known_failures.txt`" to the command below. | ||
| eval "go test -v -proxy_addr=:9999 ${configFlag}" | ||
| eval "go test -v -proxy_addr=:9999 ${configFlag} -skip `cat ../../test-proxy/known_failures.txt`" |
Contributor
There was a problem hiding this comment.
This should be:
eval "go test -v -proxy_addr=:9999 ${configFlag} -skip `tr -d '\n' < ../../testproxy/known_failures.txt`"
Contributor
Author
|
🎉 |
mutianf
approved these changes
Jan 30, 2025
sarthakbhutani
pushed a commit
to sarthakbhutani/java-bigtable
that referenced
this pull request
Feb 13, 2025
* Add known conformance test failures * Fix formatting * Typo * working dir should be root (I think) * Now the path should be right * cat file * last typo? * =( * change format * Just use regex and cat
sarthakbhutani
pushed a commit
to sarthakbhutani/java-bigtable
that referenced
this pull request
Feb 13, 2025
* Add known conformance test failures * Fix formatting * Typo * working dir should be root (I think) * Now the path should be right * cat file * last typo? * =( * change format * Just use regex and cat
sarthakbhutani
pushed a commit
to sarthakbhutani/java-bigtable
that referenced
this pull request
Feb 13, 2025
* Add known conformance test failures * Fix formatting * Typo * working dir should be root (I think) * Now the path should be right * cat file * last typo? * =( * change format * Just use regex and cat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 new flags were added to
[cloud-bigtable-clients-test](https://github.com/googleapis/cloud-bigtable-clients-test)when it upgradedcloud.google.com/go/bigtablefrom 1.33 to 1.34: googleapis/googleapis@ab2ad69This change skips the tests for those 2 flags