Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: send priming requests on the channel directly#2435

Merged
gcf-merge-on-green[bot] merged 15 commits into
googleapis:mainfrom
mutianf:primer
Dec 3, 2024
Merged

fix: send priming requests on the channel directly#2435
gcf-merge-on-green[bot] merged 15 commits into
googleapis:mainfrom
mutianf:primer

Conversation

@mutianf

@mutianf mutianf commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Send priming requests on the channel instead of using the stub. This means that we'll not collect metrics on ping and warm requests.

Fixes #2371 ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team December 2, 2024 14:59
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 2, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 2, 2024
@mutianf mutianf changed the title fix: channel primer respect other client settings fix: send priming requests on the channel directly Dec 2, 2024
@mutianf mutianf requested a review from a team December 2, 2024 19:32
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit b76698d into googleapis:main Dec 3, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 3, 2024
@mutianf mutianf deleted the primer branch December 3, 2024 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bigtable: Client side metrics opt-out is not honored in BigtableChannelPrimer

2 participants