Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

samples: fix sample versions and clean up resource#2196

Merged
mutianf merged 3 commits into
googleapis:mainfrom
mutianf:fix-sample
Apr 13, 2024
Merged

samples: fix sample versions and clean up resource#2196
mutianf merged 3 commits into
googleapis:mainfrom
mutianf:fix-sample

Conversation

@mutianf

@mutianf mutianf commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team April 12, 2024 19:29
@snippet-bot

snippet-bot Bot commented Apr 12, 2024 •
edited
Loading

Copy link
Copy Markdown

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Apr 12, 2024
@generated-files-bot

generated-files-bot Bot commented Apr 12, 2024

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label Bot added api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Apr 12, 2024
@mutianf

mutianf commented Apr 12, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2024
@mutianf

mutianf commented Apr 12, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@mutianf mutianf merged commit 3c44e18 into googleapis:main Apr 13, 2024
@mutianf mutianf deleted the fix-sample branch April 13, 2024 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kweinmeister kweinmeister

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mutianf @igorbernstein2 @kweinmeister @yoshi-kokoro