This repository was archived by the owner on Feb 24, 2026. It is now read-only.
fix: Cleanup JsonWriter bytes conversion code and add some test coverage#984
Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom Apr 7, 2021
yirutang:bytes
Merged
fix: Cleanup JsonWriter bytes conversion code and add some test coverage#984gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom yirutang:bytes
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
yirutang:bytes
Conversation
stephaniewang526
approved these changes
Apr 7, 2021
stephaniewang526
suggested changes
Apr 7, 2021
Contributor
stephaniewang526
left a comment
There was a problem hiding this comment.
Some tests after failing. PTAL @yirutang
JacobStocklass
approved these changes
Apr 7, 2021
Contributor
JacobStocklass
left a comment
There was a problem hiding this comment.
This seems a lot better with Bytes being handled as just JSONArray instead of JSONArray or String like I had it earlier. Makes the testing a lot less confusing.
stephaniewang526
approved these changes
Apr 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
============================================
- Coverage 81.03% 80.99% -0.04%
+ Complexity 1046 1045 -1
============================================
Files 78 78
Lines 5669 5668 -1
Branches 436 435 -1
============================================
- Hits 4594 4591 -3
- Misses 889 890 +1
- Partials 186 187 +1
Continue to review full report at Codecov.
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.18.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.17.0...v1.18.0) (2021-04-09) ### Features * add deprecated annotation and tag to bq storage alpha api ([#978](https://www.github.com/googleapis/java-bigquerystorage/issues/978)) ([c7da342](https://www.github.com/googleapis/java-bigquerystorage/commit/c7da34252ee8c243be3ce737d03e1e12f10a5eba)) * re-generated to pick up changes from googleapis. ([#982](https://www.github.com/googleapis/java-bigquerystorage/issues/982)) ([17bfbd8](https://www.github.com/googleapis/java-bigquerystorage/commit/17bfbd8dffd854356ea503adf3a6e065f1e1a4ee)) ### Bug Fixes * Cleanup JsonWriter bytes conversion code and add some test coverage ([#984](https://www.github.com/googleapis/java-bigquerystorage/issues/984)) ([e43df34](https://www.github.com/googleapis/java-bigquerystorage/commit/e43df3403c4d7644032cef6e1f1cf59e6ec1b5eb)) ### Documentation * update region tag for the storage quickstart ([#985](https://www.github.com/googleapis/java-bigquerystorage/issues/985)) ([1d0d6c3](https://www.github.com/googleapis/java-bigquerystorage/commit/1d0d6c3a877943b83775430d5a2bf7fcd24a1f21)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v1.127.12 ([#986](https://www.github.com/googleapis/java-bigquerystorage/issues/986)) ([d39bd79](https://www.github.com/googleapis/java-bigquerystorage/commit/d39bd79a69e987baa7721b907cdccb59d1ea4a74)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([#987](https://www.github.com/googleapis/java-bigquerystorage/issues/987)) ([4fa3dbb](https://www.github.com/googleapis/java-bigquerystorage/commit/4fa3dbba64586f6bf943ba67f225fad1b994e5a7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️