This repository was archived by the owner on Feb 24, 2026. It is now read-only.
test: E2E test for time encoding#941
Merged
stephaniewang526 merged 80 commits intogoogleapis:masterfrom Mar 24, 2021
Merged
Conversation
…d in a different PR
…omplex-schema test(Java): Jstocklass stress testing complex schema
… table insertion holds up
ddc7eb0 to
6bc03d1
Compare
stephaniewang526
suggested changes
Mar 22, 2021
Contributor
stephaniewang526
left a comment
There was a problem hiding this comment.
Hi!
- There are IT failures: https://source.cloud.google.com/results/invocations/a6ec1f57-d8d3-4ad4-8574-146b4604c560/targets ptal.
- This branch is not up-to-date against
master. Please check out master,git pull. check out this branch,git merge-- resolve any merge conflict if needed and thengit push.
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-03-18 22:45:20,095 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigquerystorage/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-03-18 22:45:21,018 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/93099bcc-ab35-48d5-ab7a-79fbfbcb0bba/targets - [ ] To automatically regenerate this PR, check this box.
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-03-22 15:32:14,816 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigquerystorage/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-03-22 15:32:15,852 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/9be4b08c-65bc-4ddb-81cf-9402bf4f1a1b/targets - [ ] To automatically regenerate this PR, check this box.
…Stocklass/java-bigquerystorage into jstocklass-time-encode-e2e
…Stocklass/java-bigquerystorage into jstocklass-time-encode-e2e
Contributor
Author
|
@stephaniewang526 I've taken care of the IT errors for the time being and I'm not sure why the integration test is failing to build. It appears that files in the proto-google-cloud-bigquerystorage-v1beta2/src/main/java/com/google/cloud/bigquery/storage/ are having a hard time finding symbols. I'm not sure if that is related to the changes made here. I've also rebased the branch against master. |
yirutang
reviewed
Mar 23, 2021
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Overall looks good, but please cleanup the extra diffs. It seems your branch is somehow newer than the current master?
...test/java/com/google/cloud/bigquery/storage/v1alpha2/BQTableSchemaToProtoDescriptorTest.java
Show resolved
Hide resolved
yirutang
approved these changes
Mar 23, 2021
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Just make sure to cleanup extra diffs.
gnanda
approved these changes
Mar 24, 2021
Comment on lines
+147
to
+148
| assertEquals("23:59:59.999999", currentRow.get(1).getRepeatedValue().get(1).getStringValue()); | ||
| assertEquals("00:00:00", currentRow.get(1).getRepeatedValue().get(2).getStringValue()); |
Contributor
There was a problem hiding this comment.
Just to verify: Is the precision difference here deterministic? Or could these tests fail later due to a precision change?
Contributor
Author
There was a problem hiding this comment.
I believe it is deterministic. The time is checked that truncating to micros is equivalent to it's original time so it should return an intentional illegal argument if the precision change were to cause a problem.
stephaniewang526
approved these changes
Mar 24, 2021
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️