Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: add a deprecation message on StreamWriter#922

Merged
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
yirutang:streamwriter
Mar 24, 2021
Merged

fix: add a deprecation message on StreamWriter#922
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
yirutang:streamwriter

Conversation

@yirutang
Copy link
Copy Markdown
Contributor

@yirutang yirutang commented Mar 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and tswast March 5, 2021 19:50
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2021 •
edited
Loading

Codecov Report

Merging #922 (dbf87a6) into master (ed33785) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #922      +/-   ##
============================================
- Coverage     80.99%   80.92%   -0.08%     
+ Complexity     1021     1020       -1     
============================================
  Files            76       76              
  Lines          5556     5556              
  Branches        426      426              
============================================
- Hits           4500     4496       -4     
- Misses          879      884       +5     
+ Partials        177      176       -1
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 82.33% <ø> (-0.92%) 32.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33785...b27fd2e. Read the comment docs.

@stephaniewang526 stephaniewang526 added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Mar 9, 2021
@stephaniewang526
Copy link
Copy Markdown
Contributor

stephaniewang526 commented Mar 9, 2021

We will come back to this once we finalized the deprecation process.

@yirutang
Copy link
Copy Markdown
Contributor Author

yirutang commented Mar 24, 2021

This is on beta API which we are going to launch in end of March.

@stephaniewang526 stephaniewang526 merged commit fce5289 into googleapis:master Mar 24, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 25, 2021
@release-please
chore: release 1.16.0 (#949)
8b71ac9 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.16.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.15.1...v1.16.0) (2021-03-25)


### Features

* Add CivilTimeEncoder to encode and decode DateTime/Time as numerics ([#937](https://www.github.com/googleapis/java-bigquerystorage/issues/937)) ([969b429](https://www.github.com/googleapis/java-bigquerystorage/commit/969b4290b9934b94b1a0113e04e37ff44b2a536e))


### Bug Fixes

* add a deprecation message on StreamWriter ([#922](https://www.github.com/googleapis/java-bigquerystorage/issues/922)) ([fce5289](https://www.github.com/googleapis/java-bigquerystorage/commit/fce52890c6948a9b78a62d2fe0e4f9768d10d401))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.10 ([#955](https://www.github.com/googleapis/java-bigquerystorage/issues/955)) ([c810c72](https://www.github.com/googleapis/java-bigquerystorage/commit/c810c7279bfbad31cb0f94f5ad5d4a74342d4481))
* update dependency com.google.cloud:google-cloud-bigquery to v1.127.9 ([#947](https://www.github.com/googleapis/java-bigquerystorage/issues/947)) ([d781dc5](https://www.github.com/googleapis/java-bigquerystorage/commit/d781dc5479602fee01eb971033978317e5669694))


### Documentation

* **samples:** Check for error from BatchCommitWriteStreams ([#940](https://www.github.com/googleapis/java-bigquerystorage/issues/940)) ([ab3c145](https://www.github.com/googleapis/java-bigquerystorage/commit/ab3c1453d3c1fb627e773d0e7ca4ec991f8d38b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@yirutang yirutang deleted the streamwriter branch April 30, 2021 19:00
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-nio to v…
c542e12 
…0.124.3 (googleapis#922)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement. status: investigating The issue is under investigation, which is determined to be non-trivial.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yirutang @stephaniewang526