Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: stop append when writer is in shutdown state.#840

Closed
yirutang wants to merge 2 commits intogoogleapis:masterfrom
yirutang:fix-shutdownappend
Closed

fix: stop append when writer is in shutdown state.#840
yirutang wants to merge 2 commits intogoogleapis:masterfrom
yirutang:fix-shutdownappend

Conversation

@yirutang
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and stephaniewang526 February 17, 2021 01:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Feb 17, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2021

Codecov Report

Merging #840 (85f1240) into master (3e86b96) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #840   +/-   ##
=========================================
  Coverage     81.14%   81.15%           
- Complexity      996      997    +1     
=========================================
  Files            74       74           
  Lines          5347     5349    +2     
  Branches        415      415           
=========================================
+ Hits           4339     4341    +2     
  Misses          838      838           
  Partials        170      170           
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 85.09% <100.00%> (+0.06%) 39.00 <4.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e86b96...e8b77f7. Read the comment docs.

@yirutang yirutang closed this Feb 17, 2021
@yirutang yirutang deleted the fix-shutdownappend branch April 30, 2021 19:00
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
)

* chore: fix license header in build.bat

* chore: add disctribution field for setup-java action
Source-Link: googleapis/synthtool@4fea5f4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:df8d7b2cc0dbc65871e7edd86601901a0612b272fa3f7f0eb590c5c53aa5f92e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant